Evergreen

Add ability to double-click on patron notes

Bug #1944717 reported by Terran McCanna
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Wishlist
Unassigned
Evergreen 3.12-beta

Bug Description

As a follow up to the notes consolidation project on https://bugs.launchpad.net/evergreen/+bug/1846354:

1) The new Notes grid doesn't allow double-clicking on a row to open the modal in edit mode (you have to make a selection and then use the action drop down)

2) Once a note has been archived, the only way to see the message is to hover over the row in the archived grid. The text appears but it is not formatted so long notes are difficult to read, and there is no way to copy and paste it. I think the ideal solution would allow for double-clicking to open it in a read-only modal. (Probably an action for that as well.)

Terran McCanna (tmccanna)
Changed in evergreen:
importance: Undecided → Wishlist
Revision history for this message
Ruth Frasur (rfrasur) wrote :

The consolidated notes interface, along with its increased functionality, has also created some increased consternation amongst our end users. The ability to double click to open both active and archived notes/alerts for full viewing would alleviate this.

Garry Collum (gcollum)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Terran McCanna (tmccanna) wrote :

Proposed patch available at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1944717_double_click_patron_notes

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.12-beta
Revision history for this message
Terran McCanna (tmccanna) wrote :

After further review, adding the ability to edit archived notes should not be permitted. Ideally, double-clicking on an archived note would open the information in a read-only modal rather than an editable modal.

tags: added: needswork
removed: pullrequest
Revision history for this message
Terran McCanna (tmccanna) wrote :

Added second commit which un-does the ability to open an archived note in edit mode. I'm not sure that it is worth the effort of adding the ability to open an archived note in read-only mode in AngularJS as this interface is currently being Angularized anyway.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1944717_double_click_patron_notes

tags: added: pullrequest
removed: needswork
Revision history for this message
Terran McCanna (tmccanna) wrote :

Okay... changed my mind and added back in the ability to double-click on archived notes to read them but removed the ability to edit them. Also added a View Note option to the Archived Notes grid. Squashed and rebased at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1944717_double_click_patron_notes

Revision history for this message
Ruth Frasur (rfrasur) wrote :

I was able to double click on both a note and edit and an archived note and NOT edit. This fix is verified. I'm signing off on this with my username, rfrasur, and email address, <email address hidden>.

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Works great! Thanks, Terran and Ruth. Pushed to main for inclusion in 3.12.

Changed in evergreen:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.