Allow Call Number attributes in Item Templates option gone

This is true in the new holdings editor in 3.8 as well.

This is a major issue for us. Our libraries use templates extensively, setting them up with as much information as possible so if inputters select the right template for a shelving location, just about everything is automatically set correctly, including classification type.

Default classification type doesn't really help us -- The classification type may be Dewey or LC in nonfiction collections, but fiction, picture books, many categories of media, etc., it's usually generic.

I tested this on the Mobius bug-squashing server and am confirming that this is still an issue on current master version of EG.

We have recently implemented using call number prefixes at our library, and I just spent many, many hours creating all new holdings templates with the prefix information. They appeared to save and they look great inside the holdings template editor and apply the prefixes. I was very excited to start using them.

However, when I opened the holdings editor to start cataloging, the prefixes don't apply.

Is this the right bug? Because my blood boiled when I realized I spent all of those hours of work creating on templates that do the same thing as my old templates. We are on 3.9.

Sarah,

Yes, this is the right bug, and it is a high priority issue for our consortium as well. We are delaying our upgrade to 3.9 until this is fixed. I have been working on this bug and have assigned it to myself, but would be more than happy to defer to someone more skillful who wants to tackle it.

I am adding a link to a (very much) WIP branch.

This branch is incomplete, it currently does two things:

- Adds a checkbox to the Holdings Editor Preferences to "Allow Call Number attributes in Item Templates". This saves the preference in the workstation setting 'eg.cat.volcopy.defaults'

- For existing templates that already include call number attributes, those call number values will be applied with the template in the holdings editor. Many thanks to Bill Erickson for providing this commit.

Still TODO:

- Add the ability to manage the call number attributes in item templates via the angular holdings editor.

Here's a link to the branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/LP1983156_callnumber_attrs_in_item_templates

user/mmorgan/LP1983156_callnumber_attrs_in_item_templates

I'm not yet adding a pullrequest and keeping this assigned to myself, but if anyone wants to address missing pieces, please feel free!

I force pushed a tweak to the same branch that assures template applied call number data is saved when editing items. Many thanks to Bill Erickson for input.

Still in progress, but adding a pullrequest tag for more eyes.

Some hastily compiled testing notes for a Concerto system:

1. Check off the following holdings editor preferences:

 - Allow Call Number attributes in Item Templates
 - Unified Holdings and Item Attributes Display

2. Create a template in the Standalone Holdings Template Editor (Administration - Local Administration - Holdings Template Editor)

3. Include Call Number attributes in your template

4. Create or Edit an item and apply your template

5. Confirm that the call number attributes are applied and saved

Another Testing note:

The AngularJS Standalone Holdings Template Editor takes it's preferences from the AngularJS volcopy editor. So to enable the "Allow Call Number attributes in Item Templates" you have to get to the Angular JS volcopy editor.

You can open up a common concerto bib in the AngularJS interface at
https://bugsquash2.mobiusconsortium.org/eg/staff/cat/catalog/record/218

Then click Add Holdings, and check the box by "Allow Call Number attributes in Item Templates"

That will allow the AngularJS Standalone Holdings Template Editor to add Prefix, Suffix and Classification to a template.

I've tested this and can confirm that Classification, Prefix and Suffix from the item template get applied in the Angular Volcopy editor after this fix is applied.

Looking into how to add the last piece of saving changes to the Classification, Prefix and Suffix back to the template when it gets saved from the Angular volcopy editor.

Josh

Here is a working branch that adds on to Michele's branch.... it doesn't handle a bunch of stuff though, but is a start.

user/stompro/LP1983156_callnumber_attrs_in_item_templates_savetemplate

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/LP1983156_callnumber_attrs_in_item_templates_savetemplate

This includes some logic to copy the current Classification, Prefix and Suffix into the template when the save button is pressed.

1. Default Values, what should and shouldn't be stored in the template. Do we always want to store the -1 for a blank prefix and suffix?

2. Currently it wipes all the call number info in the template before writing it... should fix that if needed.

3. Is there a way to tell which of those 3 fields were specifically updated?

4. Do we need to check the setting for "Allow Call Number attributes in Item Templates" and only save that info when it is enabled?

5. I didn't test when adding multiple new volumes and copies to see what happens. I think it might loop through each volume and rewrite the template for each one... probably not the best behavior.

Related Bug 1787253 - about how applying call number attributes from templates works with the batch apply actions.

In response to Josh's questions in Comment #12:

1. Default Values, what should and shouldn't be stored in the template. Do we always want to store the -1 for a blank prefix and suffix?

We would say No to always storing the default call number values in the template. Only the values changed by the user should be stored when the template is saved. We would not want a template to override an existing call number value with a default one unless the user explicitly saved it in the template.

2. Currently it wipes all the call number info in the template before writing it... should fix that if needed.

From our testing, we have not seen a problem with the current behavior.

3. Is there a way to tell which of those 3 fields were specifically updated?

My understanding is that there's no structure in place yet to highlight call number field changes the way that item field changes are highlighted. Perhaps that should be moved to a separate bug.

4. Do we need to check the setting for "Allow Call Number attributes in Item Templates" and only save that info when it is enabled?

I posted the following question to the cataloger's list:

"Can we assume that if you have set the Preference to use the "Unified Holdings and Item Attributes Display" that you would want call number attributes to be saved in item templates?"

There were no objections, so I would propose eliminating the "Allow Call Number attributes in Item Templates" and renaming the "Unified Holdings ..." option to better clarify that in the unified editor, call number fields will be saved in templates: "Unified Holdings, Item Attributes Display, and Item Templates".

5. I didn't test when adding multiple new volumes and copies to see what happens. I think it might loop through each volume and rewrite the template for each one... probably not the best behavior.

We tested this locally, and, while it may not the best behavior, we did not see any problems in our testing.

I pushed a followup branch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/LP1983156_callnumber_attrs_in_templates_savetemplate_tweaks

user/mmorgan/LP1983156_callnumber_attrs_in_templates_savetemplate_tweaks

This branch eliminates the "Allow Call Number attributes in Item Templates" setting. It also relabels the template control buttons to clearly indicate that they are template actions rather than item actions.