Evergreen

Typo on Label for Global Flag opac.located_uri.act_as_copy

Bug #1987910 reported by Erica Rohlfs
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Evergreen 3.11-beta

Bug Description

EG version 3.9

Administration > Server Administration > Global Flags

The Global Flag opac.located_uri.act_as_copy has a typo in its label.

It reads, "When enabled, Located URIs will provide visiblity behavior identical to copies."

visiblity should read visibility

Correcting the spelling and saving the change fixes it on the individual db.

Grouping it with Bug 1987908

See original description
Erica Rohlfs (erohlfs)
description: updated
Terran McCanna (tmccanna)
tags: added: admin-pages bitesize
Erica Rohlfs (erohlfs)
Changed in evergreen:
importance: Undecided → Low
Revision history for this message
Lindsay Stratton (lstratton) wrote :

Also displays typo in 3.8

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Gina Monti (gmonti90) wrote :

Here's my branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=5a8e24ed0001a921b9e90c9699df7a28f5ec06a2

Terran McCanna (tmccanna)
tags: added: pullrequest
Scott Angel (scottangel1)
tags: removed: pullrequest
Changed in evergreen:
assignee: nobody → Scott Angel (scottangel1)
Revision history for this message
Scott Angel (scottangel1) wrote :

Hey peps! I removed the pullrequest tag for the moment. I'm going to write out the sql upgrade script for this and revert the sql changes as the upgrade sql script is the more technically correct Evergreen way.

Open-ILS/src/sql/Pg/upgrade/0857.function.located_uris_act_as_copies.sql
Open-ILS/src/sql/Pg/version-upgrade/2.5.3-2.6.0-upgrade-db.sql

Revision history for this message
Scott Angel (scottangel1) wrote (last edit ):

Here is my commit
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/scottangel/lp1987910_located_uri_typo

This is the upgrade sql script.
Open-ILS/src/sql/Pg/upgrade/xxxx.data.typo-global-flag-opac-located-uri-act-as-copy.sql

I left the 950.data.seed-values.sql alone as this needed correcting.

I reverted these sql files back to the original misspellings. I know, it's a little weird but this will allow for a consistent upgrade process.
Open-ILS/src/sql/Pg/upgrade/0857.function.located_uris_act_as_copies.sql
Open-ILS/src/sql/Pg/version-upgrade/2.5.3-2.6.0-upgrade-db.sql

The upgrade sql script will correct these misspellings.

Changed in evergreen:
assignee: Scott Angel (scottangel1) → nobody
tags: added: pullrequest
Revision history for this message
Mary Llewellyn (mllewell) wrote :

Looks good!

I have tested this code and consent to signing off on it with my name, Mary Llewellyn, and my email address, <email address hidden>.

Changed in evergreen:
assignee: nobody → Mary Llewellyn (mllewell)
tags: added: signedoff
Changed in evergreen:
assignee: Mary Llewellyn (mllewell) → nobody
Galen Charlton (gmc)
Changed in evergreen:
milestone: none → 3.11-beta
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 3.11-beta. Thanks, Gina, Scott, and Mary!

Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.