Manage Authorities: the search term and authority type fields need to be associated with their labels

Bug #1989284 reported by Jane Sandberg
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.9
Fix Released
Medium
Unassigned

Bug Description

To recreate:
* Install a browser extension like WAVE or aXe
* In the staff client, go to Cataloging > Manage Authorities
* Run your accessibility extension.

WAVE flags the "Missing Form Label" error twice. aXe considers this as two separate issues: "Form elements should have a visible label" and "Form elements must have labels".

In any case, for both "Search Term" and "Authority Type" fields, there is a label visible in the screen, but it is not programmatically associated with the field it describes. We should:
1. On the Search Term input, change the erroneous "aria-describedby" attribute to "aria-labelledby".
2. Give the Authority Type combobox a domId.
3. Turn the Authority Type <span> "label" into an actual <label> tag with the new domId value in the for attribute.

More info from WebAIM: https://webaim.org/techniques/forms/controls

description: updated
Revision history for this message
Stephanie Leary (stephanieleary) wrote :
tags: added: pullrequest
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for this patch, Stephanie. Could you please set an explicit domId for the #axisCbox eg-combobox? It could potentially be somewhat fragile to rely on the autogenerated "eg-comobox-0" id. I can imagine two (probably unlikely) scenarios that could potentially lead to a mismatch:

1. If the manage authorities component is embeded in another component (maybe as a modal?), and the parent component also has a combobox.
2. If some future development adds another combobox to this component (a Thesaurus combobox, for example).

tags: added: needswork
Andrea Neiman (aneiman)
Changed in evergreen:
importance: Undecided → Medium
milestone: none → 3.next
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Updated with the ID. Thanks, Jane!

tags: removed: needswork
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Stephanie. Signoff at user/sandbergja/lp1989284-combobox-labels-signoff

tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed down to rel_3_9. Thanks, Stephanie and Jane!

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
status: New → Confirmed
milestone: 3.next → 3.10.1
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.