Evergreen

wishlist: Angular Custom OU Trees interface

Bug #1993825 reported by Andrea Neiman
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Wishlist
Unassigned
Evergreen 3.12-beta

Bug Description

This work is sponsored by King County Library System and developed by Equinox.

We will be reimplementing the Admin Custom Org Unit Trees interface in Angular, according to the specification here:

https://yeti.equinoxoli.org/dev/public/techspecs/custom_ou_trees.pdf

Terran McCanna (tmccanna)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Michele Morgan (mmorgan) wrote :

Just adding a link to related bug 1910773 - Angular Staff Catalog does not observe Custom Org Unit Trees or Org Units Do Not Inherit Visibilty global flag

Revision history for this message
Andrea Neiman (aneiman) wrote :

To clarify, Equinox's work here is a straight angularization port of the interface and does not address bug 1910773.

Andrea Neiman (aneiman)
Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Revision history for this message
Jason Etheridge (phasefx) wrote :

I've pushed a branch for this to collab/phasefx/ang-custom-org-tree-rebased2

Top five commits:
fe31f7f8a4b524e05d4e97a1cce1c85fd9346060 LP1993825 angular custom ou tree interface
41b8eb7a2d93e856c099ce502d3936a2d32d2a4e LP1993825 angular custom ou tree interface
1c8b19c69937968eb8d83c95e2604f3e6ad7bc89 Icons and ARIA for buttons
605fe1d9d69c7cfd47d575c5e62b71f55b72f28d ARIA for eg-tree
cbaee3419f140d3a91cf96d5bdd2dd66ac1d089b LP1993825 angular custom ou tree interface

Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
tags: added: pullrequest
Revision history for this message
Andrea Neiman (aneiman) wrote :

Pending a couple last changes, standby for updated pull request & docs link.

Changed in evergreen:
assignee: nobody → Andrea Neiman (aneiman)
milestone: none → 3.12-beta
tags: removed: pullrequest
Revision history for this message
Andrea Neiman (aneiman) wrote :

Docs draft here: https://docs.google.com/document/d/1yeVKgFdJutRMc3xYzuRaNSU7x3toi7MTEDpnr_rwjgw/edit?usp=sharing

also, I was mistaken about the needed changes so I am re-replacing the pull request

Changed in evergreen:
assignee: Andrea Neiman (aneiman) → nobody
tags: added: pullrequest
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Jason, Andrea, and Stephanie! I'm not familiar enough with custom org unit trees to give this a thorough test, but I did notice 3 things:

* On a screen reader, the "expand all" and "collapse all" buttons are announced identically.
* The instructions at the top of the screen were missing a step, and I got confused :-D
* This branch improves the existing tree component! That's great!

I pushed a commit for the first 2 to the collab branch. The third one is just a celebration. :-)

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Thanks, Jane! I've pushed an additional commit with styling fixes for the various buttons.

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Pushed to main (3.12) for a decisive victory in the Dojo Wars. Thanks All!

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
status: Confirmed → Fix Committed
Terran McCanna (tmccanna)
tags: added: signedoff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.