Evergreen

Prettier keyboard shortcut info modal

Bug #1999955 reported by Stephanie Leary
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned
Evergreen 3.11-beta

Bug Description

The all-lowercase keyboard shortcut labels in the AccessKeys info modal are hard to read. Branch with prettier formatting coming up.

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP1999955-pretty-keys-modal

The attached screenshot shows the difference.

Andrea Neiman (aneiman)
tags: added: pull
tags: added: pullrequest
removed: pull
Andrea Neiman (aneiman)
Changed in evergreen:
assignee: Stephanie Leary (stephanieleary) → nobody
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: none → 3.11-beta
Revision history for this message
Bill Erickson (berick) wrote :

I like the look.

I may be overthinking it, but some of the commands are not strictly correct with capitals. E.g. "Alt+S" is really "Alt+s". Is the assumption that when a capital is needed, the command will include an explicit "Shift", e.g. "Alt+Shift+S"?

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

No, the widespread best practice here is to use capital letters because that's what's printed on physical keyboards. Admittedly, virtual keyboards in mobile interfaces have muddied the waters here, but users generally understand that they are not to include the Shift key unless they see it as part of the combo.

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Hello, this looks good on https://bugsquash.mobiusconsortium.org/eg2/en-US/staff

I was a bit confused by the Angular vs AngularJs differences. Ctrl+H being the help key for one and ? being the help key for the other.

Should this change be made for the older help interface also, since they will stick around for a while yet.

I'll work on a signoff branch.
Josh

Revision history for this message
Michele Morgan (mmorgan) wrote :

Adding a link to related bug 1622358. It would still be useful for the shortcut keys to be noted in the menus.

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Signoff working branch at: user/stompro/LP1999955-pretty-keys-modal-signoff

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/LP1999955-pretty-keys-modal-signoff

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Cherry-picked for inclusion in 3.11. Thanks, Stephanie, Bill, and Josh.

Changed in evergreen:
status: New → Fix Committed
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

I agree, it would be great to have this in AngularJS as well!

Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.