When Cancelling a Hold Staff Should Only Be Able to Select Manual Cancel Reasons

Bug #2007073 reported by Jennifer Pringle
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen 3.9

When cancelling a hold through the staff catalogue, the patron account, or the holds shelf staff can currently select any cancel reason from the list, even ones that require an action that staff can't manually perform. This can lead to confusion as the cancel reason will display in the patron account on the Recently Canceled Holds tab in the Cancel Cause column.

The current list is:
- Untargeted expiration
- Hold Shelf Expiration
- Patron via phone
- Patron in person
- Staff forced
- Patron via OPAC
- Patron via SIP
- Hold Group Event rollback

The following cancel reasons should be grayed out to prevent staff from accidentally selecting them when manually cancelling holds. (Like how item statuses such as Checked Out and Lost are grayed out in the holdings editor.)

- Untargeted expiration
- Patron via OPAC
- Patron via SIP
- Hold Group Event rollback

I am on the fence about "Hold Shelf Expiration" as Evergreen will automatically cancel holds due to them expiring from the holds shelf but staff could also be handling this manually if a library manually gives different expire periods to different types of items.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Benjamin Kalish (bkalish) wrote :

This would be a great fix! Also, I'd love to see "Patron via email", as this is the most common cause I want to enter. "Patron via text" comes up occasionally too.

Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

+1 to adding "Patron via Email" and "Patron via text"

Revision history for this message
Dan Briem (dbriem) wrote :

Branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp2007073_manual_hold_cancel_causes

It might not be ideal to maintain sets of manual cause IDs in different parts of the code, so I added a field to the database instead.

It also adds Patron via email and Patron via SMS.

The list is getting longer, so rather than disable non-manual causes in the cancel hold dialogs, this just doesn't show them.

tags: added: pullrequest
Revision history for this message
Susan Morrison (smorrison425) wrote :

I have tested this code and consent to signing off on it with my name, Susan Morrison, and my email address, <email address hidden>.

Just as an fyi, the list of cancel reasons shows as:
- Hold Shelf Expiration
- Patron via phone
- Patron in person
- Staff forced
- Patron via email
- Patron via SMS

tags: added: signedoff
Changed in evergreen:
milestone: none → 3.11-beta
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Wishlist
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 3.11, along with a release notes entry. Thanks, Dan and Susan!

Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.