Evergreen

AngularJS grid can cause browser console noise

Bug #2013223 reported by Galen Charlton
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Evergreen 3.11-beta
3.10
Fix Released
Low
Unassigned
Evergreen 3.10.2
3.9
Fix Released
Low
Unassigned
Evergreen 3.9.3

Bug Description

A few AngularJS grids can spam the browser console with the following error:

  TypeError: action.handler is undefined

This is due to services/grid.js's actionDisable() function, which doesn't cleanly handle the case where the grid action is just a divider and therefore has no handler.

The affected grids are:

* hold shelf list
* AngularJS patron hold list
* renew page

Evergreen 3.9+

Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Low
tags: added: angularjs circulation
Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available in the branch user/gmcharlt/lp2013223_quell_anguarljs_grid_console_noise / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp2013223_quell_anguarljs_grid_console_noise

tags: added: pullrequest
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Signoff: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2013223_quell_anguarljs_grid_console_noise_signoff

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Nice! Merged to rel_3_9 and above. Thanks, Galen and Stephanie!

Changed in evergreen:
status: New → Fix Committed
milestone: none → 3.11-beta
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.