Use table for shelving locations in staff catalog

Branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2016742-shelving-locations-table

To test, search for anything in the staff catalog and hit the "Show More Details" button at the top of the search results. Instead of a very wide grid, you should see a shrink-to-fit table with a slightly darker background on the header row and the left column, and a count of the locations at the top in bold.

Screenshot attached.

Related:

If we go with this, we should not use additional tables for the search results, as discussed in bug 1467645. Nested tables are problematic. (Removing the outer tables in the OPAC is on my to-do list.) I have been working on the heading outline of the search results page instead (bug 2009865).

Screenshot was glitched; here's a replacement.

Nice improvement, thanks, Stephanie! My only quibble is that when navigating a list of tables (e.g. Voiceover rotor), the accessible name of the tables (provided by the <caption>) is something like "19 shelving locations". It would be a better experience if the list of tables were more like:

* "The Baroque Concerto Holdings"
* "Ready Player One Holdings"
* "Concerto in E flat major, Hob. VIIe, no. 1 for trumpet and piano Holdings"

That's a great idea, Jane. I still feel like the number is important (though not necessarily for the rotor). What about something like: "The Baroque Concerto Holdings: 19 locations"?

That sounds great to me!

This bug is the one that prompted me to ask for more guidance on localization strategies over the weekend at the conference. I've updated the branch to include the title and author, as discussed. However, this leads to an ugly mix of strings and display fields:

<caption id="caption{{index}}" *ngIf="summary.copies.length">
  <span i18n="Shelving locations table heading">{{summary.copies.length}} Shelving Locations</span>
  <span i18n="Shelving locations table heading preposition">for</span>
  <eg-bib-display-field [summary]="summary" field="title" [usePlaceholder]="true"></eg-bib-display-field>
  <span i18n="Shelving locations table heading separator">&nbsp;-&nbsp;</span>
  <eg-bib-display-field [summary]="summary" field="author" [usePlaceholder]="true"></eg-bib-display-field>
</caption>

That seems like it's going to cause problems for translators. I feel like there must be a better approach.

I am using Chrome and on test server https://bugsquash.mobiusconsortium.org/eg/staff.

I am still seeing the wide screen display on the search results screen with show more details in the angular staff catalog.

Hello, I too am still only seeing the wide screen display when I click the "Show More Details" button.

I know the Feedback Fest spreadsheet says this is loaded on a test server, but I don't think it is; I still see the old <div> markup in the inspector rather than the new <table>.

This patch doesn't merge onto main today. But I think I was able to resolve the merge conflict for bugsquash.

I tested this out and it looks to be the same. I don't see any <table> tags, only <div> so I guess there's still a merge conflict?

Tested this today (https://bugsquash2.mobiusconsortium.org/eg/staff) and it looks pretty good!

I'm seeing <table> tags - as well as the updated caption that includes both a count & the title (e.g. 19 Shelving LocationsforPiano concertos no. 13 & 15 - Mozart, Wolfgang Amadeus 1756-1791)

One thing - the "for" in the <span> between the count and the title needs spaces on either side. (&nbsp; if I remember right?)

Right now it looks like this with "LocationsforPiano" all jammed together: 19 Shelving LocationsforPiano concertos no. 13 & 15 - Mozart, Wolfgang Amadeus 1756-1791

Confirmed the spacing issue in Olivia's comment #12 so removing pullrequest until that is tweaked.

(Everything else looks great, though!)

Updated branch with the added spaces. Thanks for pointing that out, Olivia!

Note to test server admins that I had to force this update, as it was a fairly old branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2016742-shelving-locations-table

I have tested this fix and consent to adding my signoff using my username, rfrasur, and email address, <email address hidden>.

Looks great! Fix committed to 3.12 (did not apply cleanly to 3.11)

Never mind, yes it did apply to 3.11.