Evergreen

Open Non-Cataloged Circs Could Use a DB View

Bug #2019974 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Wishlist
Unassigned
Evergreen 3.12-beta

Bug Description

Evergreen 3.11 / Wishlist

Retrieving "open" non-cataloged circulations for a patron currently requires use of an open-ils.storage API (accessed via open-ils.circ). Since the query requires a join and some date math, these circs are not easily searched via cstore/pcrud. I suspect this also makes it more complicated to report on, but I'm just guessing.

The open-ils.circ.open_non_cataloged_circulation.user (and it's .batch cousin) API are frequently called in the browser client. Creating a DB view for action.open_non_cataloged_circulation and making it pcrud accessible via the IDL creates an opportunity for some minor speed/efficiency improvements for a heavily used API.

Revision history for this message
Bill Erickson (berick) wrote :

A patch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp2019974-non-cat-circ-view

From the commit:

* Make open non-cataloged circs available as a cstore/pcrud-accessible DB view.
* Migrate the public API to cstore retrieval
* Migrate one of the browser client calls to pcrud
* Minor code tidying

--

To test, make sure interfaces that display patron open non-cat circs continue to function as before.

tags: added: angular-circ circulation pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Susan Morrison (smorrison425) wrote :

Everything looks normal in the Items Out tab and when recording in-house use. Am I missing any other areas where these show up? If not, I can go ahead and sign off.

Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Susan. That's pretty much it. It's a fairly low-impact from the UI perspective.

Revision history for this message
Susan Morrison (smorrison425) wrote :

Great, thank you, Bill!

I have tested this code and consent to signing off on it with my name, Susan Morrison, and my email address, <email address hidden>.

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

This is a nice refactor! Thanks, Bill and Susan. Pushed to main for inclusion in 3.12.

Changed in evergreen:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.