Sort direction for selection depth wrong when doing best-hold selection

Bug #2023338 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Medium
Unassigned
3.10
New
Undecided
Unassigned
3.11
New
Undecided
Unassigned

Bug Description

Due to a five-character error in commit 6b53189a9 that implemented custom best-hold selection sort orders, the sorting direction for the hold selection depth is ascending, not descending.

This is a mistake: the intention is that holds that have a more limited selection depth (i.e., have a higher value for action.hold_request.selection_depth) be preferred over ones that have a broader selection depth (i.e., have a lower value for the column). The reasoning is that holds that have a broader depth also presumably have overall more copies that could fill the hold. This is particularly applicable when soft boundaries are being used.

Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Medium
Galen Charlton (gmc)
description: updated
Revision history for this message
Mike Rylander (mrylander) wrote :

I've pushed a branch to address this by inverting the selection_depth sort order in the data used to calculate the sort order for holds to test against a copy in hand:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-2023338-bhsso-selection_depth-fix

tags: added: circ-holds pullrequest
Changed in evergreen:
milestone: none → 3.12-beta
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.