remove deprecated Did You Mean library settings

Bug #2023692 reported by Galen Charlton
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Low
Unassigned

Bug Description

The Did You Mean enhancements in bug 1997485 deprecated the following six library settings and moved them to become attributes of the search class:

opac.did_you_mean.low_result_threshold
opac.did_you_mean.max_suggestions
search.symspell.keyboard_distance.weight
search.symspell.min_suggestion_use_threshold
search.symspell.pg_trgm.weight
search.symspell.soundex.weight

Those library settings were removed from the seed data and will not show up in new installations, but they were not removed outright from existing Evergreen databases on the theory that the Evergreen admin might want to review them before committing to the values to use for the search classes.

However, since those settings now do nothing, they should be removed, either for a 3.11.x point release or, at the latest, 3.12.

Galen Charlton (gmc)
tags: added: didyoumean orgunitsettings
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Branch removing the unused settings:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp2023692_remove_unused_org_settings

Safe to run on databases that do not contain the settings.

Changed in evergreen:
milestone: none → 3.12-beta
importance: Undecided → Low
status: New → Confirmed
tags: added: pullrequest
tags: added: cleanup
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbergja)
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Chris! Works for me, merged to main.

Changed in evergreen:
assignee: Jane Sandberg (sandbergja) → nobody
status: Confirmed → Fix Committed
tags: added: signedoff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.