Contrast problems with *-info, *-primary, and *-success styles

Bug #2028088 reported by Stephanie Leary
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned

Bug Description

Between the button color changes introduced in bug #1991562 and the Bootstrap 5 upgrade (bug #2000482), there are now some gaps where either background or foreground colors were specified for buttons, but not both, leading to contrast errors in hover and some disabled states.

In addition, while we updated the bg-info style for backgrounds and button outlines, we did not include an update for text styles using the info color. This has led to some unexpectedly light text in buttons in the MARC editor, among others. (Screenshot attached.)

Branch forthcoming.

Revision history for this message
Stephanie Leary (stephanieleary) wrote :
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Branch with more verbose color definitions, specifying color, background-color, and border-color for both normal and outline button styles and their disabled states: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2028088-info-contrast-fixes

Please let me know if I've missed any.

tags: added: pullrequest
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Stephanie! Signoff branch at user/sandbergja/lp2028088-info-contrast-fixes-signoff

tags: added: signedoff
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
milestone: none → 3.12-beta
Revision history for this message
Bill Erickson (berick) wrote :

Looks good here, too. Merged to main for 3.12. Thanks!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.