Staff Catalog: Default Search and Preferred Library settings are deleted when Search Preference page is loaded

I'm seeing a "Setting Update Succeeded" toast message whenever I load the Search Preferences page, regardless of whether eg.search.search_lib is set for my workstation. When it *is* set, loading the page retrieves that setting for my workstation, but then triggers an open-ils.cstore.direct.actor.workstation_setting.delete call that wipes it out. The same thing happens with eg.search.pref_lib, but not with the other search preferences.

In other words, loading the Search Preferences page deletes your Default Search Library and Preferred Library settings from the database, but this isn't obvious because the old values remain visible on the Search Preferences page after they're deleted from the db.

I think this is what's happening: eg.search.search_lib and eg.search.pref_lib are fetched when the PreferencesComponent is initialized, but the values are null when the Search Preferences page is first loaded, and this appears to trigger an update that deletes the settings. The fetch request eventually completes and updates the page with the correct values, but this happens via applyOrgId which explicitly doesn't trigger an onChange event -- so the correct values are displayed to the user but they remain deleted behind the scenes.

I've tinkered a bit but haven't been able to come up with a fix.

I've made a quick fix that won't save the contents of the Search Preferences page if the values of Default Search and Preferred Library are 0.

This appears to avoid the issue of the search preferences getting blown away when returning to the search preferences page.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=52be374ee27e44e8d777692aeb398ecbc9f68409

I have tested this, and it is working as anticipated. Something I did notice was if I made changes to my Search Preferences in the Catalog, the Search preferences under Administration-Workstation changed to match. If I made the change in Admin-Workstation, they didn't change in the Catalog Search Preferences. Is that intentional?

There is an open bug for the behavior Elizabeth described: https://bugs.launchpad.net/evergreen/+bug/1993850

Thanks Susan! I will consent to the sign-off on this code with my name, Elizabeth Davis and my email address is <email address hidden>

Works for me! Thanks Brian and all testers!

Fix committed and pushed back to 3.11.