Evergreen

MARC Batch Import/Export Queue - Some Actions No Longer Show as Links

Bug #2039310 reported by Jennifer Pringle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned
Evergreen 3.12-beta
3.11
Fix Committed
Medium
Unassigned
Evergreen 3.11.2

Bug Description

Evergreen 3.11

On the Inspect Queue tab when working within the MARC Batch Import/Export, three of the Queue Actions no longer show as links. The text is no longer blue and the cursor doesn't change to a pointer when you hover over them.

The affected links are Import Selected Records, Import All Records, Export Non-Imported Records.

The links still work, you just need to already know that they are links you can click on.

The links for View Import Items, Copy Queue To Bucket, and Delete Queue show as links as expected.

Revision history for this message
Jennifer Pringle (jpringle-u) wrote :
tags: added: accessibility
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

This is another iteration of the link/button issue in bug 2039306 (among others): <a> links must have an href or a routerLink attribute; otherwise they must be <button>s instead to ensure keyboard support for the click action. Use class="btn btn-link" to make the button look like a normal link. See https://wiki.evergreen-ils.org/doku.php?id=accessibility:links for a more detailed explanation.

Branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP2039310-vandelay-queue-links

tags: added: pullrequest
Andrea Neiman (aneiman)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 3.12-beta
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

We applied the fix to our test server and it looks and works much better than before but there's still something off with the "View Import Items" link. (see screenshot)

Looking at it again I also suspect the link should actually be named "View Imported Items" (though "View Import Items" is what it was called in the Dojo interface).

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Thanks, Jennifer, I've updated the styling on the new buttons to remove the extra spacing. Branch rebased.

Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

Looks good!

I have tested this code and consent to signing off on it with my name, Jennifer Pringle and my email address, <email address hidden>.

tags: added: signedoff
Revision history for this message
Terran McCanna (tmccanna) wrote :

Looks good! Thanks Stephanie and Jennifer!

Fix committed back to 3.11

Changed in evergreen:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.