Headings for staff catalog record views

Bug #2039483 reported by Stephanie Leary
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned

Bug Description

Following on the work from bug 1994711 to set heading 1 for all the staff pages, we now need to create subheadings to allow screen reader users to skip down the page to the appropriate section.

For the staff catalog single record view, I think "Record Summary" should be the H2, and each of the nav tabs should be H3. We don't have to change the way they look for now; they just need to be marked up as headings so they appear in screen reader users' page outline tools.

In the View Holds tab, the hold count is an H3 right now. This should change to H4 to maintain a sensible page outline. I think the only other tab that might need additional subheadings is Shelf View, where the card titles that are currently bold could be made H4 tags for extra structure.

summary: - Headings for staff catalog views
+ Headings for staff catalog record views
description: updated
Changed in evergreen:
assignee: nobody → Stephanie Leary (stephanieleary)
tags: added: accessibility staffcatalog
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

I have added the subheadings, along with the necessary CSS to avoid major visual changes to font size, weight, line height, and whitespace.

Branch here:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP2039483-staffcat-subheadings

To test, you can either use a screen reader's page navigation tools or a browser extension that simulates the landmarks and headings list; I use SkipTo Landmarks and Navigation (screenshot attached).

Previously, only 1) Staff Catalog appeared in the headings list. It is now:

1) Staff Catalog
  2) Record Summary
    3) Staff View
    3) Item Table
    3) MARC Edit
    3) MARC View
    3) Record Notes
    3) View Holds
    3) Monograph Parts
    3) Holdings View
    3) Conjoined Items
    3) Shelf Browse
      4) FIC 220 @ BR4
      4) FIC 220 @ BM1
      4) [etc.]

Does it make sense to user a lower heading level for everything after Record Summary, or should I move Staff View, etc. up to the same level?

tags: added: pullrequest
Changed in evergreen:
assignee: Stephanie Leary (stephanieleary) → nobody
Andrea Neiman (aneiman)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 3.12-beta
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Based on feedback at today's code review session, I'm going to make the tabs H2s and add a landmark for the search form.

tags: removed: pullrequest
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Headings revised! The search form already had a landmark, which I had overlooked.

The heading structure is now:

1) Staff Catalog
  2) Record Summary
  2) Staff View
  2) Item Table
  2) MARC Edit
  2) (etc.)

tags: added: pullrequest
Revision history for this message
Ruth Frasur (rfrasur) wrote :

Adding my signoff to this ticket with my name, rfrasur, and email, <email address hidden>.

tags: added: signedoff
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

I've just updated this branch to accommodate the new Added Content tab (bug 1991294).

Revision history for this message
Terran McCanna (tmccanna) wrote :

Removing signoff since there is a new update still to be tested.

tags: removed: signedoff
Revision history for this message
Ruth Frasur (rfrasur) wrote :

This will require someone to verify locally who has Novelist added content.

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

It can be tested looking at all the other tabs; the NoveList tab just needed to be made consistent to avoid merge conflicts.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks Stephanie and Ruth! Fix merged to main.

Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
status: Confirmed → Fix Committed
tags: added: signedoff
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.