Acq: When Adding a Brief Record If You Double Click "Add Record" Two Line Items Are Created

Bug #2040336 reported by Jennifer Pringle
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned
3.11
Fix Committed
Medium
Unassigned

Bug Description

Evergreen 3.11.1

When creating a brief record through a purchase order or a selection list (with the angular brief record interface) if you double click on the "Add Record" button two line items are created on your selection list or purchase order instead of just one.

Dan Briem (dbriem)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Dan Briem (dbriem) wrote :

Branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp2040336_prevent_brief_record_double_submit

This may be a challenge to test because my test server often completed the request fast enough that there weren't duplicates. Also, sometimes the extra line items only appeared on refresh.

tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Christine Morgan (cmorgan-z)
Revision history for this message
Christine Morgan (cmorgan-z) wrote :

Testing on terran-main.gapines.org during Feedback Fest. This looks good to me.

I tried several times to double click on the "Add Record" button and add two line items, refreshing the screen each time. I tried this on a selection list and on a purchase order. I was not able to make the duplicate line item issue happen.

Thanks Dan!

I have tested this code and consent to signing off on it with my name,
Christine Morgan and my email address,
<email address hidden>.

Changed in evergreen:
assignee: Christine Morgan (cmorgan-z) → nobody
tags: added: signedoff
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbergja)
Changed in evergreen:
milestone: none → 3.12-beta
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Nice fix! Thanks, Dan and Christine. Merged to rel_3_11 and above.

Changed in evergreen:
assignee: Jane Sandberg (sandbergja) → nobody
status: Confirmed → Fix Committed
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.