Evergreen

Stack Subfields are not stacking properly anymore

Bug #2040528 reported by Steve Callender
44
This bug affects 8 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned
Evergreen 3.12-beta
3.11
Fix Committed
Medium
Unassigned
Evergreen 3.11.2

Bug Description

Noticed in 3.11. When editing a MARC record with the Enhanced MARC Editor tab and using the Stack Subfields checkbox to stack the subfields, it's not longer stacking them nice and neat.

It used to stack like,

264 1
   ‡a Bothell, WA :
   ‡b The Wright Group,
   ‡c [1996]

But in 3.11 it's now looking like,

264
1
‡
a
Bothell, WA :
‡
b
The Wright Group,
‡
c
[1996]

It's putting every field on a new line.

Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

Based on the long fields I suspect this is another place affected by the fix for https://bugs.launchpad.net/evergreen/+bug/2000482

Changed in evergreen:
status: New → Confirmed
Dan Briem (dbriem)
tags: added: cat-marc
Changed in evergreen:
assignee: nobody → Dan Briem (dbriem)
Revision history for this message
Dan Briem (dbriem) wrote :

Branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp2040528_marc_edit_stack_fields_bootstrap5_fix

Bootstrap 5 removed the form-inline class and stopped applying a height calculation to its form-control class, so this replaces those with flex utility classes.

Beyond the stack subfields view, this should also apply more consistent height alignment on fields generally in the marc editor.

tags: added: pullrequest
Changed in evergreen:
assignee: Dan Briem (dbriem) → nobody
Christine Morgan (cmorgan-z)
Changed in evergreen:
assignee: nobody → Christine Morgan (cmorgan-z)
Revision history for this message
Christine Morgan (cmorgan-z) wrote :

Testing on https://terran-main.gapines.org during Feedback Fest.

I looked at a few different records. All looks good to me. The more consistent height makes for easier reading.

I have tested this code and consent to signing off on it with my name,
Christine Morgan and my email address,
<email address hidden>.

tags: added: signedoff
Changed in evergreen:
assignee: Christine Morgan (cmorgan-z) → nobody
Terran McCanna (tmccanna)
Changed in evergreen:
milestone: none → 3.12-beta
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Very nice! Thanks, Dan and Christine. Pushed to rel_3_11 and main.

Changed in evergreen:
status: Confirmed → Fix Committed
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.