open-ils.search - Z39.50 - Log error in do_class_search() - Log Noise

EG 3.11.1

There is a bug in do_class_search in Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Z3950.pm that causes log noise.

Two of these for each z39.50 search provider, if native evergreen search is also being done.

[2023-11-08 09:53:13] open-ils.search [WARN:24303:Application.pm:624:169942320622879281] open-ils.search.z3950.search_class: Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.36.0/OpenILS/Application/Search/Z3950.pm line 282.
[2023-11-08 09:53:13] open-ils.search [WARN:24303:Application.pm:624:169942320622879281] open-ils.search.z3950.search_class: Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.36.0/OpenILS/Application/Search/Z3950.pm line 282.

This line assumes that the $i variable will access the correct info, but it is off by one when the native evergreen search is also selected.

$logger->debug("z3950: Result object: $results[$i], Connection object: $connections[$i]");

Switching it it -1 index fixes it, by giving the last pushed entries instead.

Josh