Wide buttons in Record Match Sets

Bug #2043134 reported by Terran McCanna
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Low
Unassigned
3.11
Fix Committed
Low
Unassigned

Bug Description

This is a follow up to bug 2040303 - for 3.12:

The buttons in Record Match sets are unnecessarily wide which makes the page more visually confusing that it should be.

To view, go to Cataloguing -> MARC Batch Import/Export -> Record Match Set -> New Match Set. Create a new match set and then click on "Record Attribute", "MARC Tag and Subfield", or "Boolean Operator.

Screenshot of how it looks in 3.12ish and 3.10ish (before it was Angularized) attached.

Revision history for this message
Terran McCanna (tmccanna) wrote :
Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: cat-importexport ux-buttons
Changed in evergreen:
assignee: nobody → Stephanie Leary (stephanieleary)
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Pretty much any time we get super-wide buttons in Bootstrap 5, it's because the buttons are in a row but not a column. Bootstrap now assumes that anything in a row should be a block-level element, which means 100% width unless styled otherwise. Just inserting <div class="col"> (or any col-* class) between the row and its contents will fix the problem.

Here's a branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2043134-wide-match-set-buttons

I'm not super familiar with this screen, so let me know if I've overlooked anything important!

Changed in evergreen:
assignee: Stephanie Leary (stephanieleary) → nobody
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.12-beta
assignee: nobody → Terran McCanna (tmccanna)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Terran McCanna (tmccanna) wrote :

Much better, thanks Stephanie!

Fix pushed to main, 3.12, and 3.11

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Terran McCanna (tmccanna) → nobody
tags: added: signedoff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.