Certain command line options launches Exaile, if not running, even if they shouldn't

Bug #253259 reported by DeepThought
2
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Low
Unassigned

Bug Description

This applies to 0.2.13, I have not checked other versions.

If I use most of the command line options for control (such as -a or --get-length) when Exaile is not started, I get the expected message "No running Exaile instance found". However, this is not the case when using the play/pause option -t and instead of getting a message it launches Exaile.

This is also the case for --get-rating and --set-rating, however I'm not sure if that should launch the player or not.

Revision history for this message
DeepThought (verkligheten) wrote :

I don't know how to generate patches or diff-files, so I put the changes needed here manually. Change row 119-121.

From:
     running_checks = ('next', 'prev', 'stop', 'play', 'guiquery', 'get_title',
         'get_artist', 'get_album', 'get_length', 'current_position',
         'inc_vol', 'dec_vol', 'get_volume', 'query')

To:
     running_checks = ('next', 'prev', 'stop', 'play', 'play_pause', 'guiquery',
         'get_title', 'get_artist', 'get_album', 'get_length', 'current_position',
         'inc_vol', 'dec_vol', 'get_volume', 'query')

That is, add 'play_pause' to the list. Bug fixed and the --get-rating and --set-rating should actually launch the player, I guess?

Revision history for this message
Adam Olsen (arolsen) wrote :

Cleaning out old bugs.

Changed in exaile:
status: New → Invalid
Revision history for this message
Jarno Suni (jarnos) wrote :

I am using Exaile 0.3.0.1 and e.g. command "exaile --stop" launches gui, so the bug still exists.

Changed in exaile:
status: Invalid → New
reacocard (reacocard)
Changed in exaile:
importance: Undecided → Low
milestone: none → 0.3.1
status: New → Confirmed
Revision history for this message
reacocard (reacocard) wrote :

fixed trunk/2799

Changed in exaile:
status: Confirmed → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.