bzr win32 installer should include pyreadline

Bug #267674 reported by Jonny Dee
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Unassigned
BzrTools
Invalid
Undecided
Unassigned

Bug Description

I've got Python 2.5 installed on Windows and I am working with bzr.dev. I tried do use the Bazaar shell and invoked "bzr shell" on command line. However, this command returns with:

    bzr: ERROR: No module named readline
    You may need to install this Python library separately.

I did some research and it turns out that the Python installation for Windows does not ship with such a library:

    "[...]If you are using Windows, which also ships without GNU readline, you might want to consider using the pyreadline module
    instead, which is a readline replacement written in pure Python that interacts with the Windows clipboard."
    (http://pypi.python.org/pypi/readline/2.5.1)

Best regards,
Jonny

Jonny Dee (jonny.dee)
description: updated
Revision history for this message
Jonny Dee (jonny.dee) wrote : Re: Invoking "bzr shell" on Windows returns "bzr: ERROR: No module named readline"

On #bzr IRC I was suggested to install a separate "PyReadline" library for Windows, which solved my problem (http://ipython.scipy.org/moin/PyReadline/Intro).

I am leaving this bug open because I think Bazaar should mention this issue somewhere in it's documentation.

Revision history for this message
John A Meinel (jameinel) wrote :

The 'shell' command is part of bzrtools, and not bzr core. I'm a bit surprised it has a hard dependency, rather than just failing to install autocompletion if readline cannot be installed.

Vincent Ladeuil (vila)
Changed in bzr:
status: New → Invalid
Revision history for this message
Benoit Pierre (benoit.pierre) wrote :

The readline (containing PyReadline) directory is present in the lib/library.zip file in the Bazaar install directory when installed with http://launchpad.net/bzr/1.5/1.5/+download/bzr-setup-1.5.exe but not when installing with http://launchpad.net/bzr/1.6/1.6.1/+download/bzr-setup-1.6.1-1.exe. So installing 1.5, and then manually installing the bzrtools plugin works.

Revision history for this message
Benoit Pierre (benoit.pierre) wrote :

Also, patching the lib/library.zip file installed by 1.6.1: adding the readline directory from the 1.5 version seems to work.

Revision history for this message
Robert Collins (lifeless) wrote :

I think it would be reasonable to ship pyreadline in the bzr exe. We'll see what Mark thinks.

Changed in bzr:
status: Invalid → Confirmed
Revision history for this message
Kirill Müller (krlmlr) wrote :

I use bzr shell extensively. This bug hits me every time I install bazaar on a new machine _and_ every time I update bazaar. Please do update the bzr installers.

Revision history for this message
Martin Pool (mbp) wrote :

I agree with Robert, I think it would be reasonable to ship if someone will add it into the packaging recipe.

summary: - Invoking "bzr shell" on Windows returns "bzr: ERROR: No module named
- readline"
+ bzr win32 installer should include pyreadline
Changed in bzr:
importance: Undecided → Medium
Revision history for this message
Federico Bett (gfbett) wrote :

Same here with bzr 1.17. If the bzrtools plugins is shipped with the installer, every command should run out of the box.

Revision history for this message
David Roberts (smartgpx) wrote :

This behaviour confirmed to be still present in bzr-1.18rc1-1-setup.exe

Vincent Ladeuil (vila)
tags: added: packaging
Revision history for this message
Alexander Belchenko (bialix) wrote :

Year passed but the issue still remains.

John, you're building installers now on kerguelen. John, can you install on kerguelen pyreadline package from IPython team?
So, it will be bundled into standalone bzr.exe.

http://ipython.scipy.org/moin/PyReadline/Intro

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 267674] Re: bzr win32 installer should include pyreadline

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Year passed but the issue still remains.
>
> John, you're building installers now on kerguelen. John, can you install on kerguelen pyreadline package from IPython team?
> So, it will be bundled into standalone bzr.exe.
>
> http://ipython.scipy.org/moin/PyReadline/Intro
>

I've installed it. Albeit from "lp:pyreadline", but should be good
enough :).

I did a basic test with 'bzr shell' from the command line, and things
seem to work. So the only test remaining is whether it will get put into
the installer.

John
=:->

  status fixcommitted

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqKsD0ACgkQJdeBCYSNAAOm3gCeK99Htn3W+4dXHJj+HEBPganx
S5gAn0kePo07H4cAklvtZq7J6t7NlXjW
=1p70
-----END PGP SIGNATURE-----

Changed in bzr:
milestone: none → 1.18
status: Confirmed → Fix Committed
John A Meinel (jameinel)
Changed in bzr:
status: Fix Committed → Fix Released
Changed in bzrtools:
status: New → Invalid
Revision history for this message
David Roberts (smartgpx) wrote :

Was fixed in 1.18, but re-appeared in 2.1.0b4

See John's note in #11: "I've installed it. Albeit from "lp:pyreadline", but should be good enough :). "

But his comment in #2 is also pertinent: " I'm a bit surprised it has a hard dependency, rather than just failing to install autocompletion if readline cannot be installed. "

Changed in bzr:
status: Fix Released → Confirmed
Revision history for this message
David Roberts (smartgpx) wrote :

Corrected in Win32 installer for 2.1.0b4-3.

Changed in bzr:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.