Comments shouldn't be imported from auto-generated bug watches

Bug #296936 reported by Matthew Paul Thomas
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

When reporting bug 296707 I included the URL of a Trac ticket in the description. Appropriately, this did not get treated as a bug watch. But when I included the URLs of two other Trac tickets in a later comment in the same report, they were both inappropriately treated as bug watches. Launchpad then imported inappropriate comments from both of the Trac reports. This in turn means that when I try to delete one of the inappropriate bug watches, I get an oops (e.g. OOPS-1046D4100).

Just to add a little weirdness, the page in which I'm reporting this bug itself begins with six notifications, all of which say "The gobby-bugs #272 bug watch has been deleted", which isn't true.

My preferred fix to this bug, naturally, involves removing something: abolishing autogenerated bug watches altogether, in favor of on-the-fly project registration so that external bug reports can be associated with the real projects to which they belong. That's probably a fair bit of work though.

Another way of fixing it would be to make deleting a bug watch also delete any comments that were imported as a result of that bug watch.

Yet another way of fixing it would be to import external bug comments only for bug watches that were not autogenerated, and then to manually remove the inappropriately imported comments from bug 296707.

Tags: lp-bugs
Graham Binns (gmb)
Changed in malone:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Graham Binns (gmb) wrote :

Targetting this to 2.1.12 since it's actively messing with remote Trac instances, which is Bad Thing.

Changed in malone:
milestone: none → 2.1.12
Revision history for this message
Graham Binns (gmb) wrote :

The simplest fix for this (to start off with) would be to abolish comment imports for bug watches not linked to a BugTask. Autogenerated ones aren't linked to a BugTask, hence the problem becomes lessened.

Changed in malone:
milestone: 2.1.12 → 2.2.1
Changed in malone:
milestone: 2.2.1 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.