grok

Break grok.CodeView out of grok.View

Bug #392069 reported by Reinout van Rees
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
grok
Fix Released
High
Unassigned
grok 1.0

Bug Description

See http://mail.zope.org/pipermail/grok-dev/2009-April/007868.html
and http://mail.zope.org/pipermail/grok-dev/2008-September/006360.html

Splitting up View (that can use a template and/or a render() method) into a View (just uses a template) and CodeView (that uses a render() method).

Recorded as a separate issue as it is a single step that by itself helps several other issues, like possibly https://bugs.launchpad.net/bugs/243144 and https://bugs.launchpad.net/bugs/255005.

Revision history for this message
Reinout van Rees (reinout) wrote :

This is being worked on right now at the europython sprint.

Revision history for this message
Reinout van Rees (reinout) wrote :

Viewlet and Viewletmanager from grokcore.viewlet are still handling render()/template themselves, btw.

Revision history for this message
Reinout van Rees (reinout) wrote :

Everything is committed. What needs doing:

- release of grokcore.viewlet

- release of grokcore.formlib

- After those two releases, remove the trunk checkouts of above packages from the grok/branches/christiancodeviewsplit branch and pin them in the buildout and run the tests. Note: the 3 failing "sys.exit(0)" tests are unrelated and are already fixed on grok trunk.

- Merge the grok/branches/christiancodeviewsplit branch to grok trunk and change the viewlet/formlib versions in version.cfg.

Changed in grok:
status: Confirmed → Fix Committed
Revision history for this message
Reinout van Rees (reinout) wrote :

- grokcore.viewlet (1.1) and grokcore.formlib (1.2) have been released already.

- I've removed the trunk checkouts of those from the christiancodeviewsplit branch and switched them to the released versions.

- I've merged the branch onto grok trunk and upped the grokcore.viewlet/formlib/view versions in versions.cfg

All tests pass!

Michael Haubenwallner (d2m)
Changed in grok:
status: Fix Committed → Fix Released
Revision history for this message
Martijn Faassen (faassen) wrote :

for clarity, after due consideration at the Neanderthal II sprint we undid these changes. This issue can
remain closed however.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.