When resubmitting, copy reviewers

Agree about copying them, disagree about copying the approvals - but showing
"previously approved" would be good.

On Jul 16, 2009 12:05 PM, "Aaron Bentley" <email address hidden> wrote:

Public bug reported:

We should copy the reviewers from the previous merge proposal when
resubmitting. Copy approved ones across as approved, all others are
reset to pending.

** Affects: launchpad-code
    Importance: High
        Status: Triaged

** Tags: code-review

--
When resubmitting, copy reviewers
https://bugs.launchpad.net/bugs/400029
You received this bug notification because you are subscribed to
Launchpad Bazaar Integration.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Agree about copying them, disagree about copying the approvals - but showing
> "previously approved" would be good.

My reasoning was that people who have approved a proposal already are
unlikely to want to re-review it. In the rare case where a resubmission
changes a person's vote from approved to something else, they still have
the option of voting again. But if they do nothing, then their previous
approval will apply to the new version.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpfJtUACgkQ0F+nu1YWqI0b3wCfYGfvEKUKNDcoVLlJmVU41Hb9
qJgAn3Vgi2zIb4EcLpj02vg7UTX9Iqyt
=nwT0
-----END PGP SIGNATURE-----