Bug #405772 “Update to Storm 0.15” : Bugs : Launchpad itself

Revision history for this message

Stuart Bishop (stub) wrote on 2009-07-28:

#1

Targetting for 3.0 - a 0.15 release should be made before then.

Changed in launchpad-foundations:
status:	New → Triaged
importance:	Undecided → Medium
milestone:	none → 3.0

Revision history for this message

Stuart Bishop (stub) wrote on 2009-07-28:

#2

Download full text (17.1 KiB)

The code in 0.14 to better handle distinct with aggregate functions was backed out. A new fix needs to be landed before 0.15 can be released. The proposed fix is https://code.launchpad.net/~jamesh/storm/bug-217644/+merge/7680.

The Launchpad test suite has two failing tests when run against this branch. Perhaps the fix isn't complete, or perhaps we were relying on broken behavior?

File "lib/lp/registry/tests/../doc/vocabularies.txt", line 1132, in vocabularies.txt
Failed example:
   people.count() > 0
Exception raised:
   Traceback (most recent call last):
     File "/var/launchpad/test/lib/zope/testing/doctest.py", line 1360, in __run
       compileflags, 1) in test.globs
     File "<doctest vocabularies.txt[327]>", line 1, in ?
       people.count() > 0
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/store.py", line 1217, in count
       return int(self._aggregate(lambda expr: Count(expr, distinct), expr))
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/store.py", line 1206, in _aggregate
       result = self._store._connection.execute(select)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/databases/postgres.py", line 257, in execute
       return Connection.execute(self, statement, params, noresult)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/database.py", line 203, in execute
       raw_cursor = self.raw_execute(statement, params)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/databases/postgres.py", line 267, in raw_execute
       return Connection.raw_execute(self, statement, params)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/database.py", line 285, in raw_execute
       self._check_disconnect(raw_cursor.execute, *args)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/database.py", line 328, in _check_disconnect
       return function(*args, **kwargs)
     File "/var/launchpad/test/lib/canonical/ftests/pgsql.py", line 108, in execute
       return self.real_cursor.execute(*args, **kwargs)
   ProgrammingError: for SELECT DISTINCT, ORDER BY expressions must appear in select list

Failure in test lib/lp/registry/tests/../stories/foaf/xx-adminteammerge.txt
Failed doctest test for xx-adminteammerge.txt
File "lib/lp/registry/tests/../stories/foaf/xx-adminteammerge.txt", line 0

----------------------------------------------------------------------
File "lib/lp/registry/tests/../stories/foaf/xx-adminteammerge.txt", line 84, in xx-adminteammerge.txt
Failed example:
   admin_browser.getControl('Merge').click()
Exception raised:
   Traceback (most recent call last):
     File "/var/launchpad/test/lib/zope/testing/doctest.py", line 1360, in __run
       compileflags, 1) in test.globs
     File "<doctest xx-adminteammerge.txt[34]>", line 1, in ?
     File "/var/launchpad/test/lib/zope/testbrowser/browser.py", line 591, in click
       self.browser._clickSubmit(sel...

The code in 0.14 to better handle distinct with aggregate functions was backed out. A new fix needs to be landed before 0.15 can be released. The proposed fix is https://code.launchpad.net/~jamesh/storm/bug-217644/+merge/7680.

The Launchpad test suite has two failing tests when run against this branch. Perhaps the fix isn't complete, or perhaps we were relying on broken behavior?

File "lib/lp/registry/tests/../doc/vocabularies.txt", line 1132, in vocabularies.txt
Failed example:
   people.count() > 0
Exception raised:
   Traceback (most recent call last):
     File "/var/launchpad/test/lib/zope/testing/doctest.py", line 1360, in __run
       compileflags, 1) in test.globs
     File "<doctest vocabularies.txt[327]>", line 1, in ?
       people.count() > 0
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/store.py", line 1217, in count
       return int(self._aggregate(lambda expr: Count(expr, distinct), expr))
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/store.py", line 1206, in _aggregate
       result = self._store._connection.execute(select)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/databases/postgres.py", line 257, in execute
       return Connection.execute(self, statement, params, noresult)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/database.py", line 203, in execute
       raw_cursor = self.raw_execute(statement, params)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/databases/postgres.py", line 267, in raw_execute
       return Connection.raw_execute(self, statement, params)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/database.py", line 285, in raw_execute
       self._check_disconnect(raw_cursor.execute, *args)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/database.py", line 328, in _check_disconnect
       return function(*args, **kwargs)
     File "/var/launchpad/test/lib/canonical/ftests/pgsql.py", line 108, in execute
       return self.real_cursor.execute(*args, **kwargs)
   ProgrammingError: for SELECT DISTINCT, ORDER BY expressions must appear in select list

Failure in test lib/lp/registry/tests/../stories/foaf/xx-adminteammerge.txt
Failed doctest test for xx-adminteammerge.txt
 File "lib/lp/registry/tests/../stories/foaf/xx-adminteammerge.txt", line 0

----------------------------------------------------------------------
File "lib/lp/registry/tests/../stories/foaf/xx-adminteammerge.txt", line 84, in xx-adminteammerge.txt
Failed example:
   admin_browser.getControl('Merge').click()
Exception raised:
   Traceback (most recent call last):
     File "/var/launchpad/test/lib/zope/testing/doctest.py", line 1360, in __run
       compileflags, 1) in test.globs
     File "<doctest xx-adminteammerge.txt[34]>", line 1, in ?
     File "/var/launchpad/test/lib/zope/testbrowser/browser.py", line 591, in click
       self.browser._clickSubmit(self.mech_form, self.mech_control, (1,1))
     File "/var/launchpad/test/lib/zope/testbrowser/browser.py", line 380, in _clickSubmit
       self.mech_browser.open(form.click(
     File "/var/launchpad/test/lib/mechanize/_mechanize.py", line 177, in open
       return self._mech_open(url, data)
     File "/var/launchpad/test/lib/mechanize/_mechanize.py", line 202, in _mech_open
       response = UserAgent.open(self, self.request, data)
     File "/var/launchpad/test/lib/mechanize/_opener.py", line 234, in open
       response = urlopen(self, req, data)
     File "/usr/lib/python2.4/urllib2.py", line 376, in _open
       '_open', req)
     File "/usr/lib/python2.4/urllib2.py", line 337, in _call_chain
       result = func(*args)
     File "/var/launchpad/test/lib/zope/testbrowser/testing.py", line 131, in http_open
       return self.do_open(PublisherConnection, req)
     File "/usr/lib/python2.4/urllib2.py", line 993, in do_open
       h.request(req.get_method(), req.get_selector(), req.data, headers)
     File "/var/launchpad/test/lib/zope/testbrowser/testing.py", line 84, in request
       self.response = self.caller(request_string, handle_errors)
     File "/var/launchpad/test/lib/canonical/testing/layers.py", line 1277, in my__call__
       form=form)
     File "/var/launchpad/test/lib/zope/app/testing/functional.py", line 691, in __call__
       request = publish(request, handle_errors=handle_errors)
     File "/var/launchpad/test/lib/zope/publisher/publish.py", line 133, in publish
       result = publication.callObject(request, obj)
     File "/var/launchpad/test/lib/canonical/launchpad/webapp/publication.py", line 373, in callObject
       return mapply(ob, request.getPositionalArguments(), request)
     File "/var/launchpad/test/lib/zope/publisher/publish.py", line 108, in mapply
       return debug_call(obj, args)
     File "/var/launchpad/test/lib/zope/publisher/publish.py", line 114, in debug_call
       return obj(*args)
     File "/var/launchpad/test/lib/canonical/launchpad/webapp/publisher.py", line 276, in __call__
       return self.render()
     File "/var/launchpad/test/lib/lp/registry/browser/peoplemerge.py", line 110, in render
       return super(AdminMergeBaseView, self).render()
     File "/var/launchpad/test/lib/canonical/launchpad/webapp/launchpadform.py", line 127, in render
       return self.template()
     File "/var/launchpad/test/lib/zope/app/pagetemplate/viewpagetemplatefile.py", line 83, in __call__
       return self.im_func(im_self, *args, **kw)
     File "/var/launchpad/test/lib/zope/app/pagetemplate/viewpagetemplatefile.py", line 51, in __call__
       sourceAnnotations=getattr(debug_flags, 'sourceAnnotations', 0),
     File "/var/launchpad/test/lib/zope/pagetemplate/pagetemplate.py", line 115, in pt_render
       strictinsert=0, sourceAnnotations=sourceAnnotations)()
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 271, in __call__
       self.interpret(self.program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 891, in do_useMacro
       self.interpret(macro)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 536, in do_optTag_tal
       self.do_optTag(stuff)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 521, in do_optTag
       return self.no_tag(start, program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 516, in no_tag
       self.interpret(program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 855, in do_condition
       self.interpret(block)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 855, in do_condition
       self.interpret(block)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 949, in do_defineSlot
       self.interpret(slot)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 891, in do_useMacro
       self.interpret(macro)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 861, in do_defineMacro
       self.interpret(macro)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 957, in do_defineSlot
       self.interpret(block)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 536, in do_optTag_tal
       self.do_optTag(stuff)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 521, in do_optTag
       return self.no_tag(start, program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 516, in no_tag
       self.interpret(program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 891, in do_useMacro
       self.interpret(macro)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 536, in do_optTag_tal
       self.do_optTag(stuff)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 521, in do_optTag
       return self.no_tag(start, program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 516, in no_tag
       self.interpret(program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 824, in do_loop_tal
       self.interpret(block)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 536, in do_optTag_tal
       self.do_optTag(stuff)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 521, in do_optTag
       return self.no_tag(start, program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 516, in no_tag
       self.interpret(program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 861, in do_defineMacro
       self.interpret(macro)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 536, in do_optTag_tal
       self.do_optTag(stuff)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 521, in do_optTag
       return self.no_tag(start, program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 516, in no_tag
       self.interpret(program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 855, in do_condition
       self.interpret(block)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 536, in do_optTag_tal
       self.do_optTag(stuff)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 521, in do_optTag
       return self.no_tag(start, program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 516, in no_tag
       self.interpret(program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 855, in do_condition
       self.interpret(block)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 534, in do_optTag_tal
       self.no_tag(stuff[-2], stuff[-1])
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 516, in no_tag
       self.interpret(program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 745, in do_insertStructure_tal
       structure = self.engine.evaluateStructure(expr)
     File "/var/launchpad/test/lib/zope/tales/tales.py", line 696, in evaluate
       return expression(self)
     File "/var/launchpad/test/lib/zope/tales/expressions.py", line 217, in __call__
       return self._eval(econtext)
     File "/var/launchpad/test/lib/zope/tales/expressions.py", line 211, in _eval
       return ob()
     File "/var/launchpad/test/lib/zope/app/pagetemplate/viewpagetemplatefile.py", line 83, in __call__
       return self.im_func(im_self, *args, **kw)
     File "/var/launchpad/test/lib/zope/app/pagetemplate/viewpagetemplatefile.py", line 51, in __call__
       sourceAnnotations=getattr(debug_flags, 'sourceAnnotations', 0),
     File "/var/launchpad/test/lib/zope/pagetemplate/pagetemplate.py", line 115, in pt_render
       strictinsert=0, sourceAnnotations=sourceAnnotations)()
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 271, in __call__
       self.interpret(self.program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 855, in do_condition
       self.interpret(block)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 536, in do_optTag_tal
       self.do_optTag(stuff)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 521, in do_optTag
       return self.no_tag(start, program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 516, in no_tag
       self.interpret(program)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 346, in interpret
       handlers[opcode](self, args)
     File "/var/launchpad/test/lib/zope/tal/talinterpreter.py", line 586, in do_setLocal_tal
       self.engine.setLocal(name, self.engine.evaluateValue(expr))
     File "/var/launchpad/test/lib/zope/tales/tales.py", line 696, in evaluate
       return expression(self)
     File "/var/launchpad/test/lib/zope/tales/expressions.py", line 217, in __call__
       return self._eval(econtext)
     File "/var/launchpad/test/lib/zope/tales/expressions.py", line 194, in _eval
       ob = self._subexprs[-1](econtext)
     File "/var/launchpad/test/lib/zope/tales/expressions.py", line 124, in _eval
       ob = self._traverser(ob, element, econtext)
     File "/var/launchpad/test/lib/zope/app/pagetemplate/engine.py", line 68, in __call__
       request=request)
     File "/var/launchpad/test/lib/zope/traversing/adapters.py", line 164, in traversePathElement
       return traversable.traverse(nm, further_path)
     File "/var/launchpad/test/lib/zope/traversing/adapters.py", line 44, in traverse
       attr = getattr(subject, name, _marker)
     File "/var/launchpad/test/lib/canonical/cachedproperty.py", line 78, in __get__
       result = self.fn(inst)
     File "/var/launchpad/test/lib/canonical/widgets/popup.py", line 94, in matches
       search_results = vocab.searchForTerms(formValue)
     File "/var/launchpad/test/lib/lp/registry/vocabularies.py", line 625, in searchForTerms
       return CountableIterator(results.count(), results, self.toTerm)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/store.py", line 1217, in count
       return int(self._aggregate(lambda expr: Count(expr, distinct), expr))
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/store.py", line 1206, in _aggregate
       result = self._store._connection.execute(select)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/databases/postgres.py", line 257, in execute
       return Connection.execute(self, statement, params, noresult)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/database.py", line 203, in execute
       raw_cursor = self.raw_execute(statement, params)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/databases/postgres.py", line 267, in raw_execute
       return Connection.raw_execute(self, statement, params)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/database.py", line 285, in raw_execute
       self._check_disconnect(raw_cursor.execute, *args)
     File "/var/launchpad/tmp/eggs/storm-0.14jamesh_storm_bug_217644_311-py2.4-linux-x86_64.egg/storm/database.py", line 328, in _check_disconnect
       return function(*args, **kwargs)
     File "/var/launchpad/test/lib/canonical/ftests/pgsql.py", line 108, in execute
       return self.real_cursor.execute(*args, **kwargs)
   ProgrammingError: for SELECT DISTINCT, ORDER BY expressions must appear in select list

Revision history for this message

Stuart Bishop (stub) wrote on 2009-07-28:

#3

Branch that uses the updated Storm is lp:~stub/launchpad/update-storm

Revision history for this message

James Henstridge (jamesh) wrote on 2009-07-30:

#4

I've uploaded r312 of my lp:~jamesh/storm/bug-217644 branch, which should fix the above problem (and probably not introduce new ones).

Revision history for this message

Stuart Bishop (stub) wrote on 2009-07-30:

#5

The full test suite passes with r312 of James' Storm branch.

Revision history for this message

Stuart Bishop (stub) wrote on 2009-08-03:

#6

Launchpad devel is now running with lp:storm r321.

Guilherme Salgado (salgado) on 2009-10-26

Changed in launchpad-foundations:
assignee:	nobody → Stuart Bishop (stub)
status:	Triaged → Fix Released

Revision history for this message

Michael Nelson (michael.nelson) wrote on 2010-08-23:

#7

There are a number of XXX references to bug 217644 in the code.

Changed in soyuz:
status:	New → In Progress
assignee:	nobody → Michael Nelson (michael.nelson)
milestone:	none → 10.09

Revision history for this message

Launchpad QA Bot (lpqabot) wrote on 2010-08-25: Bug fixed by a commit

#8

Fixed in stable r11421 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11421>.

tags:	added: qa-needstesting
Changed in soyuz:
status:	In Progress → Fix Committed

Michael Nelson (michael.nelson) on 2010-08-25

tags:

added: qa-untestable
removed: qa-needstesting

Launchpad QA Bot (lpqabot) on 2010-08-26

tags:

added: qa-needstesting
removed: qa-untestable

Julian Edwards (julian-edwards) on 2010-08-27

tags:

added: qa-untestable
removed: qa-needstesting

Curtis Hovey (sinzui) on 2010-09-09

Changed in soyuz:
status:	Fix Committed → Fix Released

Launchpad itself

Update to Storm 0.15

Bug Description

Related branches

Other bug subscribers

Remote bug watches