lastfmcoverart plugin for exaile works with old lastfm api

Bug #421658 reported by Alex Turowskiy
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Low
Ubuntuxer

Bug Description

First of all, i've noticed that cover art from lastfm is extremely small (80×80px), even though on the page of album a larger version. Then i've look at plugin file and see that it use a old version of lastfm API.
Next, i've tried to make a link for info.xml of some album. There was links to 3 versions of cover art for that album (small, medium and large) and none of them was 80×80px.

If there are need of it, i use openSUSE 11.1, exaile 0.3.

reacocard (reacocard)
Changed in exaile:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Ubuntuxer (johannes-schw) wrote :

Hi, I rewrote the plugin to support the new API, so it downloads bigger covers.
But the plugin isn't matured yet. I'm a beginner, so I'm grateful about any help.
Why the images aren't saved in the album's direcory. I don't change it, because I suppose there is a reason.

Revision history for this message
Ubuntuxer (johannes-schw) wrote :

I improved the plugin, so that it searches for the track title, if the album weren't found.

Revision history for this message
Johannes Sasongko (sjohannes) wrote : Re: [Bug 421658] Re: lastfmcoverart plugin for exaile works with old lastfm api

Looks OK to me, but whose API key is that? I think we should use
Adam's (it may be in 0.2.x), and it should be made a constant.

Revision history for this message
Johannes Sasongko (sjohannes) wrote :

Targetting 0.3.1.

Changed in exaile:
assignee: nobody → Ubuntuxer (johannes-schw)
status: Confirmed → In Progress
milestone: none → 0.3.1
Revision history for this message
Ubuntuxer (johannes-schw) wrote :

I copied the API key from the example url. http://www.last.fm/api/show?service=357

I fixed a small bug, adjust the version number and add myself to the authors.

Revision history for this message
reacocard (reacocard) wrote :

I've registered an API key for Exaile on last.fm: 3599c79a97fd61ce518b75922688bc38

Revision history for this message
Ubuntuxer (johannes-schw) wrote :

Is it better if the user can select the cover size out of a list. (small, medium, large, extralarge, mega)
What do you think about to convert the cover into a certain image format, if desired.

Revision history for this message
reacocard (reacocard) wrote :

I don't know what those size categories correspond to in terms of pixels, but if we can't sensibly pick a default that will work for basically all users, then I have no problem with making it an option.

Conversion to a particular format will only be relevant if we add support for saving downloaded art to other locations. As long as the images are only used internally, I don't see any point in converting them, and in any case the conversion would not happen inside the last.fm support plugin, but rather the covers framework itself.

Revision history for this message
Ubuntuxer (johannes-schw) wrote :

I added a simple Gui, so you can select the cover size. But the label 'extralarge' is misleading, because it's just 300x300 pixel.

I hope the patch will be committed.

Revision history for this message
reacocard (reacocard) wrote :

patch committed lp:exaile/2678

Changed in exaile:
status: In Progress → Fix Committed
Revision history for this message
Johannes Sasongko (sjohannes) wrote :

Honestly if the largest covers are just 300x300, we could just use that and not complicate it with an option, IMHO.

Revision history for this message
Ubuntuxer (johannes-schw) wrote :

@Sasongko Actually you're right, but I wouldn't change it now.

But I detect an other bug already:
If the a cover isn't found the plugin shouldn't return a blank array. Instead the plugin should raise a NoCoverFoundException(), so that e.g. jamendo search the cover.

Revision history for this message
reacocard (reacocard) wrote :

I did change the default to 'extralarge' before i committed.

Revision history for this message
Ubuntuxer (johannes-schw) wrote :

I wrote a patch, which fix my previous patch and the cover manager. I removed the GUI because it's just useless.
I'm sorry for the inconvenience caused to you.

Revision history for this message
reacocard (reacocard) wrote :

patch committed trunk/2679

reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.