Switch to GtkBuilder

Bug #425034 reported by Mathias Brodala
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
High
Mathias Brodala

Bug Description

As discussed numerous times Exaile should abandon the libglade format and switch to GtkBuilder.

Mathias Brodala (mathbr)
Changed in exaile:
assignee: nobody → Mathias Brodala (mathbr)
importance: Undecided → Wishlist
milestone: none → 0.3.1
importance: Wishlist → High
status: New → Confirmed
Revision history for this message
Johannes Sasongko (sjohannes) wrote :

For the record, xlgui/prefs/widgets already supports plugin prefs in both Libglade and GtkBuilder formats. If you do a check on the file extension (.glade vs .ui) it should be easy enough to support both, if only to smooth the transition temporarily, given that they follow very similar API.

Revision history for this message
Johannes Sasongko (sjohannes) wrote :

I meant xlgui/prefs/__init__, sorry. The relevant code is inside the switch_pane function. It checks whether the page has a 'ui' or 'glade' attribute, but checking the file extension would be just as easy.

Revision history for this message
reacocard (reacocard) wrote :

> I meant xlgui/prefs/__init__, sorry. The relevant code is inside the switch_pane
> function. It checks whether the page has a 'ui' or 'glade' attribute, but checking
> the file extension would be just as easy.

It's probably better to leave it as-is, file extension based detection is much more fragile than simply allowing the developer to specify which format to use.

Mathias Brodala (mathbr)
Changed in exaile:
status: Confirmed → In Progress
Mathias Brodala (mathbr)
Changed in exaile:
status: In Progress → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.