bin/test --layer=MailmanLayer no longer works

Bug #429375 reported by Barry Warsaw
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Björn Tillenius

Bug Description

It used to be that "bin/test --layer=MailmanLayer" would run just the MailmanLayer tests, which are normally disabled. Now, it seems that --layer is ignored and all tests are run.

Related branches

Revision history for this message
Björn Tillenius (bjornt) wrote :

--layer isn't being ignored. The issue is that bin/test specifies some default options, that you can't remove. One of those options is "--layer=!MailmanLayer". This means that if you run "bin/test --layer=MailmanLayer", it's like running "bin/test --layer=!MailmanLayer --layer=Mailmanlayer", which means: run all layer that aren't MailmanLayer, as well as those layers that are MailmanLayer.

There are a few different options for fixing this. My favourite so far is to only add those default options if it isn't specifed in the command line. I.e., if you pass in --layer=foo, don't add the default --layer option. If you pass in -s or --package, don't add the default --package options.

Changed in launchpad:
assignee: nobody → Barry Warsaw (barry)
Revision history for this message
Björn Tillenius (bjornt) wrote :

I'll fix this, since I need this to work for windmill tests.

affects: launchpad → launchpad-foundations
Changed in launchpad-foundations:
assignee: Barry Warsaw (barry) → Björn Tillenius (bjornt)
status: New → In Progress
tags: added: story-windmill-layer
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Changed in launchpad-foundations:
milestone: none → 3.0
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.