Launchpad itself

registering slot is in a terrible place

Bug #434399 reported by Tim Penhey on 2009-09-22

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Launchpad itself	Fix Released	High	Curtis Hovey	Launchpad itself 3.0

Look at any branch when running launchpad locally (or on edge for that matter).
https://code.launchpad.dev/~name12/gnome-terminal/scanned

The registering slot to me looks very very wrong.

IMO it should be under the horizontal line (that is under the app buttons), flush right, above the side portlets if there are any.

I've had a brief attempt to get this right myself, but I can't seem to get the CSS right for everything :-(

Tags:

Merged into lp://qastaging/launchpad

Jeroen T. Vermeulen (community): Approve on 2009-09-23

Martin Albisetti (beuno) on 2009-09-22

Changed in launchpad:
status:	New → Triaged
assignee:	Martin Albisetti (beuno) → Curtis Hovey (sinzui)

Revision history for this message

Curtis Hovey (sinzui) wrote on 2009-09-22:

I have a branch that moves the slot.

Revision history for this message

Jonathan Lange (jml) wrote on 2009-09-22:

Added malone, since apparently it's using different infrastructure to the other parts of Launchpad.

Revision history for this message

On Tue, 22 Sep 2009 22:10:23 Curtis Hovey wrote:
> I have a branch that moves the slot.
>
> ** Attachment added: "registering in the header"
> http://launchpadlibrarian.net/32250265/registering.png

Please not above the line.

It now looks like the registration information applies to the primary context,
not the branch in this image.

That is why I suggested below the line.

However if I'm given the choice of above the line or where it is now, then
I'll take above the line, but really I think it should be below the line.

Revision history for this message

Martin Albisetti (beuno) wrote on 2009-09-22:

On Tue, Sep 22, 2009 at 9:48 PM, Tim Penhey <email address hidden> wrote:
> Please not above the line.

The line is gone in devel.

--
Martin

Revision history for this message

Diogo Matsubara (matsubara) wrote on 2009-09-23: Bug fixed by a commit

Changed in malone:
status:	New → Fix Committed

Curtis Hovey (sinzui) on 2009-09-23

Changed in launchpad:
status:	Triaged → Fix Committed
affects:	launchpad → launchpad-foundations
Changed in launchpad-foundations:
milestone:	none → 3.0
Changed in malone:
milestone:	none → 3.0