Please add a GetCoverPath method to Dbus

Bug #434787 reported by Steve Dodier-Lazaro
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Wishlist
Unassigned

Bug Description

Everything is in the title.

Please add a method that returns the path to the cover for the current track, or None when not possible.

reacocard (reacocard)
Changed in exaile:
status: New → Confirmed
Revision history for this message
Johannes Sasongko (sjohannes) wrote :

I guess GetTrackCover or GetCoverPath, or something similar would be a better name. Alternatively, we could make this available as one of the __internal "tags".

Revision history for this message
reacocard (reacocard) wrote :

GetCoverPath sounds best to me. Exposing it as an internal tag doesn't really make sense as the cover db is disjoint from the main db.

Revision history for this message
Steve Dodier-Lazaro (sidi) wrote : Re: [Bug 434787] Re: Please add a GetCoverTrack method to Dbus

I actually meant GetCoverPath but made a typo while writing. Thanks for
pointing it out.

summary: - Please add a GetCoverTrack method to Dbus
+ Please add a GetCoverPath method to Dbus
Revision history for this message
Jaap Broekhuizen (jaapz-b) wrote :

Could this be added please, i need it for notify-osd and CoverGloobus, its really a drawback of Exaile not being able getting the album cover :(

Revision history for this message
Jaap Broekhuizen (jaapz-b) wrote :

Fixed this! Edited the xl/xldbus.py file so it also sends the cover path trough dbus with the GetCoverPath method. That method just queries the cover database for the cover of the current playing song.
The patch is included as an attachment. :)

Revision history for this message
Kaivalagi (m-buck) wrote :

Thanks for the patch, updated the source locally and I now have a working dbus call for my app :)

Revision history for this message
Kaivalagi (m-buck) wrote :

Any chance the cover art image path returned is one which isn't such a small resolution, I recall previous versions of exaile returned cover art image paths which resulted in a much better quality. The image path returned is for the scaled down version used by exaile which is only 64x64 pixels... :(

Revision history for this message
reacocard (reacocard) wrote :

patch committed trunk/2559

Kaivalagi - we only store the full size cover we get from our sources and downsize it as needed. the returned path is for the full size cover; if its small, it because the cover exaile has stored is small.

Changed in exaile:
status: Confirmed → Fix Committed
Revision history for this message
Kaivalagi (m-buck) wrote :

Thanks for the clarification Aren, must have been a bad choice of cover art in my testing, I look forward to the next release :)

reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.