Can't determine paused state from D-Bus
Bug #434820 reported by
Johannes Sasongko
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Exaile |
Fix Released
|
Medium
|
Hakan Erduman | ||
Bug Description
Currently we only have IsPlaying, which is quite misleading and returns whether the playback is not stopped (i.e., playing or paused). A better solution is probably a GetState method, reflecting player.get_state (but maybe returning an integer?).
While fixing this we need to decide what happens with IsPlaying. Either we can remove it and break apps that's already using the new API, modify it to return whether the player is actually playing, or we keep the method around and deprecate it.
Thanks to Steve Dodier for pointing out the inconsistency between IsPlaying and player.is_playing.
Related branches
lp://qastaging/~aquaherd/exaile/dbus
(Merged)
Revision history for this message
| Hakan Erduman (aquaherd) wrote | #1 |
| Changed in exaile: | |
| assignee: | nobody → Hakan Erduman (aquaherd) |
| Changed in exaile: | |
| status: | Confirmed → In Progress |
| Changed in exaile: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| reacocard (reacocard) wrote | #2 |
| Changed in exaile: | |
| milestone: | none → 0.3.1 |
| Changed in exaile: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
'state' used to be published in the 0.2. series as returning the strings
'playing', 'paused' and 'stopped'.
I'd suggest restoring the previous behaviour than making a translation.