When adding playlist entries from a collection folder via the Files panel, take it from the Collection

Bug #435738 reported by Alexander Bethke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Medium
Unassigned

Bug Description

Use case:
I like ordering my music on the file system, e.g. I put new additions to my library into a "New" folder aso. All those folders like "New" are also in my collection (Exaile db).
This gives me the possibility to have different views on my library. I can either access them through the Collection tab (or the dynamic playlist) or on the other hand via the Files tab by the subjective categories I applied via putting stuff into different folders. I love that Exaile gives me that flexibility (and that's why I came to Exaile in the first place).

Here comes the problem:
When I add playlist entries from one of those folders that are in the collection form the Files panel, the Files panel does faithfully what it always does and scans the meta info and adds it as an out-of-collection entry. This of course excludes the use of things that are based on additional meta data that is only in the collection like the rating-facility or play-count.

My take on making up a solution:
So couldn't it be done so that if a playlist entry is added from the Files panel that it is checked if it actually exists in the collection and take the reference form the collection instead. This check would only be performed for entries that are under one of the folders that make up the collection.
I (wildly) guess that there should not be a performance hit, as the additional time needed to check for existence of the file in the collection would be compensated by not having to parse the file for meta data. The only situation when the loading from Files panel would get slower is when the file is inside a folder that belongs to the collection, but the file itself not in the collection. Hence when the collection is out of sync with the file system, and that is anyway an exceptional state, isn't it? In that case the loading could fall back to the standard file loading.

Please correct me when I'm wrong about my assumptions.

I'm running exaile 0.3.1+ from bzr on Ubuntu Jaunty.

Revision history for this message
reacocard (reacocard) wrote :

Single Track instances per loc should already be enforced in bzr and already cause this to happen.

Changed in exaile:
importance: Undecided → Medium
status: New → Incomplete
Revision history for this message
reacocard (reacocard) wrote :

more accurately, bzr rev 2504 or later should enforce this.

Revision history for this message
Alexander Bethke (oolongbrothers) wrote :

Oh. Well I should really be more careful, update to HEAD and check again before making noise here.

Everything I wished for above is actually working in bzr. Couldn't either provoke any flaws. Great, thanks for reading my mind and putting up with my noise here.

Marking as Fix Committed.

Changed in exaile:
status: Incomplete → Fix Committed
reacocard (reacocard)
Changed in exaile:
milestone: none → 0.3.1
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.