Awn

All windows of the same app gets the main app icon when grouping is disabled.

Bug #465763 reported by Marcos Jr
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Awn
Fix Released
Medium
moonbeam

Bug Description

When grouping is disabled, each window that an app opens (such as pidgin chat windows) gets the main app icon instead of window's icon.

Gnome's default taskbar and even awn "long-press dialog" show's the correct icon of that windows.

---
* Distribution: Ubuntu 9.10 (Karmic)
* Method of installing Awn: From ppa repo: http://ppa.launchpad.net/awn-testing/ppa/ubuntu
* Awn version: 0.3.9-rewrite-bzr1621-karmic1-1
* Window manager: Default of karmic with compiz
* Video card and driver name/version: nVidia GeForce Go 6150 - Driver version 185

Tags: taskmanager
Revision history for this message
Marcos Jr (junalmeida) wrote :
Mark Lee (malept)
Changed in awn:
assignee: nobody → moonbeam (rcryderman)
importance: Undecided → Low
tags: added: taskmanager
Revision history for this message
moonbeam (rcryderman) wrote :

There are a couple things going on here.

First is that the default configuration (/apps/awn-applet-taskmanager/disable_icon_changes ) is to not show the window icons in the task icon (ever).

Second, is that the current code only uses the app icon _if_ the window icon is changed after the window appears is appears. This works quite well with a lot of apps but not with Pidgin (and probably a few others). There are a couple reasons for attempting this: some applications tend to provide very low quality window icons (Open Office is a long lasting example of this) and the fact that the icons specified in desktop files often do not match the icons that apps provide as Window icons.

That being said:

Sometime in the next couple days I will be pushing the following changes:
1) Changing the default of /apps/awn-applet-taskmanager/disable_icon_changes so the Window icons are displayed. I don't guarantee that this will remain the default but I won't consider changing it again before the setting is exposed in awn-settings.
2) Removing the logic that only used the Window icon if the app changed the icon after the fact (this should fix the Pidgin issue). Not that this will probably lead to, what some will regard, as undesirable icons appearing in the Taskmanager.

and probably

3) Adding an additional modifier that attempts to be smart and only use the Window icon when it contains useful info (some variation on what it does currently). It will probably be some variation on the current approach that special cases apps that identified as being currently a problem.

Changed in awn:
status: New → In Progress
importance: Low → Medium
Revision history for this message
moonbeam (rcryderman) wrote :

Rev 1628 implements 2.

Revision history for this message
Marcos Jr (junalmeida) wrote :

As a suggestion, i guess that tasks that have launchers should keep launcher's .desktop icon or customized icon. Just new opened windows of that task should show its X icon.

Revision history for this message
Mark Lee (malept) wrote :

@MarcosJr:
I just want to point out that what you described was the (only) behavior in the 0.2/0.3 series, and people complained that the icons were neither pretty nor consistent. :) Hence, moonbeam's efforts to create an algorithm to give tasks pretty, consistent icons.

Revision history for this message
moonbeam (rcryderman) wrote :

Several additional commits 1629, 1635-1637 that resolve additional issues / cleanup relevant code.

Revision history for this message
Marcos Jr (junalmeida) wrote :

@MarkLee:
I guess that the old behavior is the most optimal in case of apps that use low quality icons. This way, we can have a better quality on app's main window (the launcher), and also easy identify the purpose of other windows opened by that app.

But people could also report the low quality icons to the development of each app. :)

Michal Hruby (mhr3)
Changed in awn:
milestone: none → 0.4.0
moonbeam (rcryderman)
Changed in awn:
status: In Progress → Fix Committed
moonbeam (rcryderman)
Changed in awn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.