Local cover display broken in most plugins

Bug #486678 reported by Alexander Bethke
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Medium
Unassigned

Bug Description

Hi, I'm trying to hunt down problems with local cover display I have since some time in 0.3.1+, currently running on r2660.

Except for the main now playing display, local covers are not shown in most plugins. This applies for the notifyosd popups, context info and the desktop cover plugins. However the cover is correctly shown in the AWN plugin.

If I switch to the lastfm cover provider, covers are correctly shown in all the places.

Here is what exaile --debug logs to stdout when I start playing a track (local cover provider).

INFO : Playing file:///home/alex/Audio/test/Foo/01_Doll.mp3 (xl.player.engine_normal)
INFO : Attempting to find covers for 'Doll' from 'The Colour and the Shape' by 'Foo Fighters' (xl.cover)
INFO : Found covers from local (xl.cover)
DEBUG : Setting AWN cover to '/home/alex/Audio/test/Foo/cover.jpg' (awn)
INFO : Attempting to find covers for 'Doll' from 'The Colour and the Shape' by 'Foo Fighters' (xl.cover)
INFO : Found covers from local (xl.cover)
DEBUG : Setting AWN cover to '/home/alex/Audio/test/Foo/cover.jpg' (awn)
DEBUG : Getting cover for 'Doll' from 'The Colour and the Shape' by 'Foo Fighters' (notifyosd_cover)
DEBUG : Did not find cover, using DEFAULT_COVER (notifyosd_cover)
DEBUG : Using image '/media/Data/Entwicklung/exaile/data/images/nocover.png' (notifyosd_cover)
INFO : Attempting to find covers for 'Doll' from 'The Colour and the Shape' by 'Foo Fighters' (xl.cover)
INFO : Found covers from local (xl.cover)
INFO : Attempting to find covers for 'Doll' from 'The Colour and the Shape' by 'Foo Fighters' (xl.cover)
INFO : Found covers from local (xl.cover)
INFO : Attempting to find covers for 'Doll' from 'The Colour and the Shape' by 'Foo Fighters' (xl.cover)
INFO : Found covers from local (xl.cover)
INFO : Attempting to submit "Now Playing" information to AudioScrobbler... (audioscrobbler)
Traceback (most recent call last):
  File "/media/Data/Entwicklung/exaile/data/plugins/desktopcover/__init__.py", line 123, in _display
    pixbuf = gtk.gdk.pixbuf_new_from_file(cover)
glib.GError: Failed to open file 'file:///home/alex/Audio/test/Foo/cover.jpg': No such file or directory
DEBUG : Searching for 10 tracks related to 'Doll' from 'The Colour and the Shape' by 'Foo Fighters' (xl.dynamic)
INFO : Submitted "Now Playing" successfully to AudioScrobbler (_scrobbler)

Context info in that case then just swallows the whole playing-panel the cover would reside in. notifyosd shows the fallback image and desktop cover does not appear at all any more.

The path is actually correct. and when I ctrl-click on it in the console, it opens the correct file.

Regards, Alex

Revision history for this message
Johannes Sasongko (sjohannes) wrote :

Confirmed. Note: The "obvious" fix of doing gio.File(uri).get_path() will likely fail if the URI is a remotely mounted GIO volume (e.g. an smb: or sftp: URI).

Changed in exaile:
importance: Undecided → Medium
milestone: none → 0.3.1
status: New → Confirmed
Revision history for this message
reacocard (reacocard) wrote :

It looks like the 'proper' way to do this is handle the IO ourselves, and pass the data to gtk.gdk.PixbufLoader for rendering. should probably wrap this into a convenience function in guiutil.

Revision history for this message
reacocard (reacocard) wrote :

the new covers system should have fixed this, reopen if this is not the case.

Changed in exaile:
status: Confirmed → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.