poor handling of missing replaygain element

Bug #490898 reported by reacocard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
High
reacocard
exaile (Fedora)
Fix Released
Medium

Bug Description

Presently, if the replaygain elements are missing from the user's gstreamer installation, the replaygain plugin will cause Exaile to crash during player init on start with a "gst.ElementNotFoundError: rgvolume" error. This needs to be fixed by

1) Making the replaygain plugin's enable() check for the element, and raise an exception if it is missing

2) Making the player pipeline (specifically ElementBin) resistant to missing elements during setup

Revision history for this message
In , Chad (chad-redhat-bugs) wrote :

abrt 1.0.0 detected a crash.

Comment: happens upon start

backtrace
-----
Summary: TB322f570b __init__.py:62:__init__:ElementNotFoundError: rgvolume

Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/exaile/exaile.py", line 56, in <module>
    main()
  File "/usr/lib/python2.6/site-packages/exaile/exaile.py", line 53, in main
    exaile = main.Exaile()
  File "/usr/lib/python2.6/site-packages/exaile/xl/main.py", line 90, in __init__
    self.__init()
  File "/usr/lib/python2.6/site-packages/exaile/xl/main.py", line 155, in __init
    self.player = player.get_player()()
  File "/usr/lib/python2.6/site-packages/exaile/xl/player/engine_normal.py", line 40, in __init__
    pre_elems=[pipe.ProviderBin("stream_element")])
  File "/usr/lib/python2.6/site-packages/exaile/xl/player/pipe.py", line 181, in __init__
    self.reset_providers()
  File "/usr/lib/python2.6/site-packages/exaile/xl/player/pipe.py", line 187, in reset_providers
    self.elements[provider.index] = provider()
  File "/usr/share/exaile/plugins/replaygain/__init__.py", line 62, in __init__
    self.rgvol = gst.element_factory_make("rgvolume")
ElementNotFoundError: rgvolume

Local variables in innermost frame:
self: /GstBin:rgvolume (ReplaygainVolume)

cmdline: python /usr/lib/python2.6/site-packages/exaile/exaile.py --datadir=/usr/share/exaile/data --startgui
component: exaile
executable: /usr/lib/python2.6/site-packages/exaile/exaile.py
kernel: 2.6.31.6-145.fc12.x86_64
package: exaile-0.3.0.1-1.fc12
uuid: 322f570b

Revision history for this message
In , Chad (chad-redhat-bugs) wrote :

Created attachment 376768
File: backtrace

Revision history for this message
In , Chad (chad-redhat-bugs) wrote :

Feel free to contact me by email if more information is needed. <email address hidden>

Revision history for this message
In , Dominic (dominic-redhat-bugs) wrote :

Is this issue reproducible with exaile 0.3.0.2? You can obtain a package from here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1836589

Revision history for this message
In , Chad (chad-redhat-bugs) wrote :

Yes, it appears to be the same error.

INFO : Loading Exaile 0.3.0.2...
INFO : Loading settings...
INFO : Setting up deferred idle manager function...
INFO : Loading plugins...
INFO : Loading collection...
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/exaile/exaile.py", line 56, in <module>
    main()
  File "/usr/lib/python2.6/site-packages/exaile/exaile.py", line 53, in main
    exaile = main.Exaile()
  File "/usr/lib/python2.6/site-packages/exaile/xl/main.py", line 90, in __init__
    self.__init()
  File "/usr/lib/python2.6/site-packages/exaile/xl/main.py", line 155, in __init
    self.player = player.get_player()()
  File "/usr/lib/python2.6/site-packages/exaile/xl/player/engine_normal.py", line 40, in __init__
    pre_elems=[pipe.ProviderBin("stream_element")])
  File "/usr/lib/python2.6/site-packages/exaile/xl/player/pipe.py", line 181, in __init__
    self.reset_providers()
  File "/usr/lib/python2.6/site-packages/exaile/xl/player/pipe.py", line 187, in reset_providers
    self.elements[provider.index] = provider()
  File "/usr/share/exaile/plugins/replaygain/__init__.py", line 62, in __init__
    self.rgvol = gst.element_factory_make("rgvolume")
gst.ElementNotFoundError: rgvolume

Revision history for this message
In , Chad (chad-redhat-bugs) wrote :

Should I post a separate bug report for that version?

Changed in exaile (Fedora):
status: Unknown → Confirmed
Revision history for this message
In , Dominic (dominic-redhat-bugs) wrote :

No, there is no need for a separate bug report, we can handle this within this issue I think. My question was just intended to clarify if the issue maybe already got fixed with Exaile 0.3.0.2.
I found this issue is known and will most likely be fixed with upcoming Exaile 0.3.0.3. There is an existing bug concerning this at the Exaile tracker which can be found here: https://bugs.launchpad.net/fedora/+source/exaile/+bug/490898

Revision history for this message
In , Chad (chad-redhat-bugs) wrote :

Thank you for your help.

Changed in exaile (Fedora):
status: Confirmed → In Progress
Revision history for this message
reacocard (reacocard) wrote :

part 2 is done in trunk - exaile will no longer crash if it cant create an element.

Revision history for this message
reacocard (reacocard) wrote :

fixed in trunk/2785

Changed in exaile:
milestone: 0.3.0.3 → 0.3.1
status: Triaged → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

exaile-0.3.1.0-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/exaile-0.3.1.0-1.fc11

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

exaile-0.3.1.0-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/exaile-0.3.1.0-1.fc12

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

exaile-0.3.1.0-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with
 su -c 'yum --enablerepo=updates-testing update exaile'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/exaile-0.3.1.0-1.fc11

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

exaile-0.3.1.0-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with
 su -c 'yum --enablerepo=updates-testing update exaile'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/exaile-0.3.1.0-1.fc12

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

exaile-0.3.1.0-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

exaile-0.3.1.0-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.

Changed in exaile (Fedora):
importance: Unknown → Medium
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.