Exaile

Rating criteria broken in trunk

Bug #508134 reported by Kevin Knerr
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Critical
reacocard
Exaile 0.3.1

Bug Description

Exaile 2812 via bzr update
Ubuntu Karmic (9.10) 64-bit

The rating criteria in smart playlists is limited to an integer range (-8 to 8). However, the ratings reported via properties are now displayed as percentage based floating point ( 1 star = 20.0 ... 5 stars = 100.0 ). As a result, all existing smart playlists using a rating criteria are broken--all tracks are excluded. You might think that "rating >0" would work, but even this returns no results.

I even checked "rating > -1"--all tracks are still excluded.

This did not affect exaile_0.3.0.2-0ppakarmic1. The bug has been introduce in trunk at some point after that release.

reacocard (reacocard)
Changed in exaile:
assignee: nobody → Aren Olson (reacocard)
importance: Undecided → Critical
milestone: none → 0.3.1
status: New → Confirmed
Revision history for this message
reacocard (reacocard) wrote :

fixed trunk/2814

Changed in exaile:
status: Confirmed → Fix Committed
Revision history for this message
Steve Dodier-Lazaro (sidi) wrote :

Hi,

I still see a few things that could be improved for rating in smart playlists:

- It's not possible to select unrated tracks at the moment, even with rating at most 0. How are these tracks represented exactly? Could you please add an option to select only unrated tracks? That would definitely help in rating one's new tracks.

- At the moment the rating in expressed in number of stars. But does 5 always translate to 100%, or does it translate to 5/<number of stars> * 100 % ? I didn't manage to find this in the code (thus no patch coming :P).

- At the moment, rating goes from -8 to 8. I think it wouldn't be too hard to make it go from -<nb stars> to <nb stars> instead.

Revision history for this message
reacocard (reacocard) wrote :

improved sure, but it _works_ now, which it didn't before :P

trunk/2819 addresses some of the issues you mentioned. "rating at most 0" now works properly, and rating will go from 0 to "miscellaneous/rating_steps".

As for your second point, the value is stored and converted to 0-100 at the time the smart playlist does its search, using value/steps * 100%.

reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.