h.264 encoding does not work with newest FFmpeg

OK - I've confirmed the problem seems to be that the codec parameters aren't set, attached is a quick-and-dirty patch which "fixes" libx264 output by setting up the codec parameters.

After applying the patch choosing x.264 video within an mp4 container (haven't tried other containers yet) produces a file with both audio *and* video (which plays OK in mplayer).

Although you could, perhaps, use this for v1.1 I think that there should really be some way of editing these. Certainly for x.264 and probably there should be a more generic "advanced codec configuration" dialog.

Thanks a lot for the patch. Do you test the others containers ? It will a great helpfull.
Thanks

Your patch seems to work for me as well, output with libx264 is fixed

I have forgotten to tell that's will be included in the next version.

> I have forgotten to tell that's will be included in the next version.

Ok, then the same change probably needs to be made in cli_render.py as well.

correct, herre it is a patch that's supposed to fix h264 output in command-line rendering too.

I need to test this patch against the current versions of ffmpeg and mlt, to make sure it won't break all of the users on older versions. If all tests work, then we can merge this into the 1.1 code. Thanks!

I'm running mlt 4.10 and ffmpeg-0.5-6.20100116svn from rpmfusion - that's about as current as you can get without pulling development versions (I've done that too but not run openshot against the result yet).

Hello,

Have these patches been integrated into 1.1 Alpha1? On AV Linux 3.0R1 (Debian Testing) all x264 exports from Openshot are still not working (audio with no video) using ffmpeg 0.5+svn20100126, libx264-83, and melt 0.4.10 on Openshot 1.1 Alpha1. I would suggest this is a fairly urgent fix as x264 in all it's various forms is a very common export format.

No, the patch has not been integrated into 1.1 yet. But it is planned very soon. =)

Jonathan,

That's great news! I can't wait.

@ptf Thanks so much for providing these patches, IMHO this has been a big one to get sorted out.

In the meantime forgive my ignorance but how can these patches be integrated into an existing Openshot install?

Hello GMag
Find the last version of openshot by :
bzr branch lp:openshot
go in the folder
cd openshot
download le patch
wget http://launchpadlibrarian.net/39067639/render_options_for_x264.patch (or by another way)
add the patch by :
patch -p 0 < render_options_for_x264.patch
after
python setup.py build
cd bin
./openshot
I hope to be clear, i'm not a specialist and you have more explanations here : http://openshotusers.com/forum/viewtopic.php?f=11&t=204

I have just seen that Jonathan had merged the patch in the branch. So, you have just to get back the last version on launchpad.
Thanks and Great distribution (AVLinux). Could you create a torrent please ? Thanks.

cenwen

Thanks for all your help! I'll look into a torrent in the near future.

Thanks Jonathan, an upstream donation from AV Linux is coming your way soon!

Seems to work great. I have committed this to the trunk. Thanks!