Add HTTP authentication support for standalone mode
Bug #518724 reported by
Mark Lee
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| loggerhead |
In Progress
|
Low
|
Mark Lee | ||
| loggerhead-breezy |
Triaged
|
Low
|
Unassigned | ||
Bug Description
I have added optional support for HTTP basic and digest authentication for the case where one is running loggerhead without a proxy in front of it (such as Apache), but does not wish to have the branch viewer "public". It uses Paste's built-in support for both kinds of auth (plus an htpasswd parser for basic auth from the Trac project, BSD-licensed), so there are no new external dependencies introduced (as HTTP auth support seems to have been in Paste since 0.4).
Related branches
lp://qastaging/~malept/loggerhead/standalone-auth
- Krisztian Eyssen (community): Approve
- Max Kanat-Alexander (community): Needs Fixing
- Michael Hudson-Doyle: Approve
-
Diff: 240 lines (+189/-0)4 files modifiedNEWS (+3/-0)
loggerhead/config.py (+11/-0)
loggerhead/htpasswd.py (+139/-0)
loggerhead/main.py (+36/-0)
Revision history for this message
| Martin Albisetti (beuno) wrote | #1 |
| Changed in loggerhead: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in loggerhead: | |
| assignee: | nobody → Mark Lee (malept) |
| status: | Triaged → In Progress |
Revision history for this message
| Richie Ward (richies) wrote | #2 |
Revision history for this message
| Robert Collins (lifeless) wrote | #3 |
| Changed in loggerhead: | |
| importance: | High → Low |
| Changed in loggerhead-breezy: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
To post a comment you must log in.
Setting importance to high as this actually has a patch :)
Could you file a merge proposal for it?
The code looks good to me, in an ideal world we'd have tests for this, but I think the testsuite is currently broken due to some issue with imports.