Exaile

Streamripper keeps recording after stop

Bug #522779 reported by phanyx on 2010-02-16

8

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Exaile	Fix Released	Medium	Ubuntuxer	Exaile 0.3.1

Bug Description

Hello,

Exaile keeps recording radio streams even after unpressing the rec button (or even after closing Exaile). Recording can be stopped only by killing the streamripper process.

I found out, that every pressing and unpressing the rec button leads to opening new streamripper process. In other words, instead of stopping a streamripper, unpressing the rec button starts new streamripper process (so that's two record processes by this moment).

Recording itself works fine.

Clicking the rec button gives following messages in terminal:
"Traceback (most recent call last):
File "/usr/share/exaile/plugins/streamripper/__init__.py", line 82, in toggle_record
logger.info("Using streamripper to play location: %s" % track['__loc'])
TypeError: 'Track' object is unsubscriptable"

Ubuntu+Xfce 9.10 2.6.31-20-generic.
Exaile ver. 0.3.1b from `deb http://ppa.launchpad.net/exaile-devel/ubuntu karmic main'
Streamripper-plugin ver. 0.0.1
Streamripper ver. 1.64.6-1

Regards,
phan

Revision history for this message

Steve Dodier-Lazaro (sidi) wrote on 2010-02-19:

#1

Thanks for your report. Adding the bug to the 0.3.1 milestone.

Changed in exaile:
importance:	Undecided → Medium
milestone:	none → 0.3.1

Ubuntuxer (johannes-schw) on 2010-02-19

Changed in exaile:
assignee:	nobody → Ubuntuxer (johannes-schw)

Revision history for this message

Ubuntuxer (johannes-schw) wrote on 2010-02-20:

#2

streamripper.diff Edit (15.5 KiB, text/plain)

I've rewritten the streamripper plugin. Streamripper is terminated now and the folder incomplete is removed.

Please test my patch and let me know if it resolves the issue.

Revision history for this message

Ubuntuxer (johannes-schw) wrote on 2010-02-20:

#3

widgets.diff Edit (487 bytes, text/plain)

This patch fix the open directory dialog.

Revision history for this message

Ubuntuxer (johannes-schw) wrote on 2010-02-23:

#4

streamripper.diff Edit (17.6 KiB, text/plain)

I've revised my patch and add an option to delete incomplete files.
Now, the streamripper plugin should really work, like expected.

Revision history for this message

Ubuntuxer (johannes-schw) wrote on 2010-02-26:

#5

streamripper2.diff Edit (17.3 KiB, text/plain)

I've improved the clarity by dividing the code into two classes. I haven't done any functional changes.

Revision history for this message

Ubuntuxer (johannes-schw) wrote on 2010-02-26:

#6

__init__.py Edit (5.1 KiB, text/plain)

I had forgotten to terminate streamripper if Exaile is closed. Now it's fixed.

Revision history for this message

Ubuntuxer (johannes-schw) wrote on 2010-02-28:

#7

streamripper3.diff Edit (18.1 KiB, text/plain)

Oops, here is the diff file of streamripper and the tiny bug fix in widgets.

I hope this patch will be commited soon. It isn't just a bug fix, but I think the new features are manageable.

Changed in exaile:
status:	New → In Progress

Revision history for this message

Steve Dodier-Lazaro (sidi) wrote on 2010-03-01: Re: [Bug 522779] Re: Streamripper keeps recording after stop

#8

Well, if you introduce too many changes it will be more risky to get it into
0.3.1 since we're approaching the release. Are you 100% positive that your
code works properly and is safe to merge?

Revision history for this message

Ubuntuxer (johannes-schw) wrote on 2010-03-01:

#9

Yes, I think so. The changes of the patch are:
The streamripper process is terminated cleanly, if Exaile is closed, a stream is stopped or a new stream is started.
Add an option to delete incomplete files and to rip to single file.
Besides this patch fix the open folder dialog.

Revision history for this message

reacocard (reacocard) wrote on 2010-03-01:

#10

> Besides this patch fix the open folder dialog.

Please remove that from the patch. A patch should have exactly one goal, not two. This makes managing regressions much easier.

Revision history for this message

Ubuntuxer (johannes-schw) wrote on 2010-03-01:

#11

I know, my fault.
The bear thing is that it isn't possible in Launchpad to attach more than one diff file simultaneously and I thought it's just a tiny patch.

Please remove the lasts lines from patch streamripper3.diff and use patch widgets.diff I had attached before.
Thanks.

Revision history for this message

reacocard (reacocard) wrote on 2010-03-01:

#12

> it isn't possible in Launchpad to attach more than one diff file simultaneously

Just add one on one comment and add another on a blank comment -- that's standard practice on lp. However in this case since the second patch is for an unrelated item, it should go in a different bug report rather than as a second patch on this one.

Revision history for this message

Ubuntuxer (johannes-schw) wrote on 2010-03-02:

#13

streamripper4.diff Edit (17.6 KiB, text/plain)

I've opened a new bug report 530517 and attach a cleaned patch.

Revision history for this message

reacocard (reacocard) wrote on 2010-03-06:

#14

committed trunk/2880

Changed in exaile:
status:	In Progress → Fix Committed

reacocard (reacocard) on 2010-03-16

Changed in exaile:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

Add patch

Remote bug watches

Bug watches keep track of this bug in other bug trackers.