Exaile

Bug in method find_similar_tracks()

Bug #538289 reported by Ubuntuxer on 2010-03-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Exaile	Fix Released	Low	Unassigned	Exaile 0.3.1

Bug Description

1. If you call the method without the optional argument limit, the method returns a empty list, instead of the whole list.

2. The methode raise a DebrecationWarning, because the outdated method search() from the class TrackDB is used to check wether the similiar artist is in the collection.

Revision history for this message

Ubuntuxer (johannes-schw) wrote on 2010-03-13:

dynamic.diff Edit (971 bytes, text/plain)

I've written a small patch, which should fix this two issues. The problem is that the search in the collection doesn't work. I don't understand why. Why is the method search from the class TrackDB marked as deprecated?

Revision history for this message

reacocard (reacocard) wrote on 2010-03-13:

It's deprecated because when we refactored the search system, it became a lot less tied to the TrackDB object itself. Deprecating TrackDB.search helps enforce this separation in code. Additionally, it is likely that TrackDB will be merged into Collection at some point, when that happens the search method will be removed completely.

Revision history for this message

reacocard (reacocard) wrote on 2010-03-13:

patch committed trunk/2890