Preferences dialog should better fit HIG

Bug #585115 reported by moimael
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Medium
Unassigned

Bug Description

Hi,

I have some suggestion to improve the preferences dialog in openshot.

First, why do not use normal GtkNotebook for the category ? It save place and it's more consistent with the rest of the desktop.

Why do not make the theme selection instant apply instead of showing a preview ? That's recommended by HIG and save place too.

The project type should not appear in the preference dialog, it would be better to remove it. It should be plain text by defaut and if it's binary, it should be handled by code.

The history max step option should use a gtkspinbutton.

The big button in the profiles category is ugly, why do not embed directly the profile window in the preference window ?

I attached a patch who made some thing i suggested. It work great and make the code simplier. What i plan to do is removing the apply and cancel button and replace them with a close button and save changes when the focus change.

Tell me what you think !

Thanks.

Tags: patch

Related branches

moimael (moimael)
Changed in openshot:
importance: Undecided → Wishlist
Revision history for this message
moimael (moimael) wrote :

A more conform preferences dialog who apply settings when focus change and with a close button (plus a minor ui fix).

Changed in openshot:
milestone: none → 1.2.0
Revision history for this message
Andy Finch (fincha) wrote :

The Image Length text box should probably also be changed to a gtkspinbutton...

Revision history for this message
moimael (moimael) wrote :

A new patch made against the last revision, with the image length text box changed to a spin button like andy suggested ;)

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Thanks for the patch! This has been applied and committed to the trunk. We now have a more HIG compliant preferences screen! Also, the project file type has officially been defaulted to ASCII.

Changed in openshot:
importance: Wishlist → Medium
status: New → Fix Committed
Revision history for this message
Jonathan Thomas (jonoomph) wrote :

I have applied some new patches (from moimael) to the preferences screen, as well as improved the profile manager's integration with the parent preferences profile dropdown. The entire profile manager is much better integrated now. Thanks!

Andy Finch (fincha)
Changed in openshot:
status: Fix Committed → Fix Released
tags: added: patch
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.