It's still possible to hit a NullBugTask
Bug #589701 reported by
Graham Binns
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
William Grant | ||
Bug Description
According to bug 365489 NullBugtask is no longer in use. However, it's still possible to hit a NullBugTask (and thus get an OOPS if you try to do anything with it) by visiting a long-form URL of a package bug that has no distro task in the context of the distro. E.g.: https:/
If you visit the short form of the bug URL Launchpad will redirect you to a usable context; Launchpad should do the same if you visit the distro context since it makes no sense otherwise.
Related branches
lp://qastaging/~wgrant/launchpad/unuse-nullbugtask
- Tim Penhey (community): Approve (code)
- Steve Kowalik (community): Approve (code*)
-
Diff: 479 lines (+43/-198)6 files modifiedlib/lp/bugs/browser/bugnomination.py (+1/-9)
lib/lp/bugs/browser/bugtask.py (+6/-130)
lib/lp/bugs/browser/configure.zcml (+21/-43)
lib/lp/bugs/browser/tests/bug-views.txt (+2/-2)
lib/lp/bugs/browser/tests/bugtask-edit-views.txt (+13/-13)
lib/lp/bugs/templates/bugtask-index.pt (+0/-1)
lp://qastaging/~wgrant/launchpad/hide-inaccessible-bugs
- Steve Kowalik (community): Approve (code)
-
Diff: 419 lines (+31/-159)16 files modifiedlib/canonical/launchpad/browser/launchpad.py (+1/-1)
lib/canonical/launchpad/pagetests/basics/notfound-traversals.txt (+2/-2)
lib/canonical/launchpad/pagetests/webservice/security.txt (+2/-4)
lib/lp/bugs/browser/bugtask.py (+7/-5)
lib/lp/bugs/browser/malone.py (+1/-1)
lib/lp/bugs/browser/tests/bugtask-edit-views.txt (+0/-78)
lib/lp/bugs/browser/tests/test_bugattachment_file_access.py (+3/-3)
lib/lp/bugs/browser/tests/test_bugtask.py (+2/-2)
lib/lp/bugs/stories/bug-privacy/20-private-distro-bug-not-visible-to-anonymous.txt (+1/-1)
lib/lp/bugs/stories/bug-privacy/30-private-distro-bug-not-visible-to-nonsubscriber-user.txt (+1/-1)
lib/lp/bugs/stories/bug-privacy/xx-presenting-private-bugs.txt (+2/-2)
lib/lp/bugs/stories/bugtracker/xx-bugtracker-remote-bug.txt (+1/-1)
lib/lp/bugs/stories/cve/xx-cve-link-to-modified-target.txt (+0/-39)
lib/lp/bugs/stories/upstream-bugprivacy/10-file-private-upstream-bug.txt (+3/-3)
lib/lp/bugs/stories/upstream-bugprivacy/30-private-upstream-bug-not-accessible-to-anonymous.txt (+3/-10)
lib/lp/bugs/stories/upstream-bugprivacy/50-private-upstream-bug-not-accessible-to-nonsubscriber-user.txt (+2/-6)
Revision history for this message
| Diogo Matsubara (matsubara) wrote | #1 |
| tags: | added: oops |
| Changed in launchpad: | |
| importance: | Low → Critical |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| Changed in launchpad: | |
| milestone: | none → 11.04 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Another example of a NullBugTask being hit: OOPS-1671O585 (AttributeError: can't set attribute)