ec2 land should trust the merge proposal approver
Bug #607434 reported by
Francis J. Lacoste
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Jonathan Lange |
Bug Description
On the following merge proposal: https:/
Robert voted 'Needs fixing' and then set the merge proposal to 'Approved' to mean: fix the small stuff, but you are free to merge.
After I made, the small changes, I tried to use ec2 land and got the following error:
ec2: ERROR: Cannot land branches that haven't got approved code reviews. Get an 'Approved' vote so we can fill in the [r=REVIEWER] section.
I would suggest using the merge approval approver to fill in the r= in such a case.
Related branches
lp://qastaging/~jml/launchpad/various-ec2-fixes
- j.c.sackett (community): Approve
-
Diff: 278 lines (+102/-24)5 files modifiedlib/devscripts/autoland.py (+19/-5)
lib/devscripts/ec2test/builtins.py (+26/-8)
lib/devscripts/ec2test/instance.py (+7/-2)
lib/devscripts/ec2test/tests/test_remote.py (+6/-2)
lib/devscripts/tests/test_autoland.py (+44/-7)
Changed in launchpad-foundations: | |
status: | New → Triaged |
importance: | Undecided → Low |
tags: | added: build-infrastructure |
tags: | added: ec2land ec2test |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Jonathan Lange (jml) |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12721 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12721>.