pyclient does not refresh default layout

Yeah - you're right.

That code is new for 1.2.0a2 to support the new schedule format. All the other layouts in there get created fresh each time so I don't suppose it should be an issue if it were updated every time.

I don't see though how your code is working.

http://bazaar.launchpad.net/~xibo-maintainers/xibo/biela/annotate/head%3A/client/python/XiboClient.py#L2001

That code block is only executed if there is a schedule change. So unless there is a schedule change accompanied by the default layout change then the change will still be missed.

I need to think about this some more.

Alex

I've thought that maybe the try-except block can be useful,
so I modified it, this way:
                    try:
                        if self.__defaultLayout.layoutID != layoutID or True:
                           self.__defaultLayout = XiboLayout(layoutID,True)
                    except:
                        self.__defaultLayout = XiboLayout(layoutID,True)

Ah you are referring to this condition:
    if self.previousSchedule != schedule:
I didn't check the reason but I saw that this
is true at every iteration.

On Thu, 2010-09-09 at 11:02 +0000, Andrea wrote:
> Ah you are referring to this condition:
> if self.previousSchedule != schedule:
> I didn't check the reason but I saw that this
> is true at every iteration

OK - it shouldn't be.

Alex

This email carries a disclaimer, a copy of which may be read at http://learning.longhill.org.uk/disclaimer

The value of self.previousSchedule is not changed anywhere.

On Thu, 2010-09-09 at 12:00 +0000, Andrea wrote:
> The value of self.previousSchedule is not changed anywhere.

That'll be why then :D

This email carries a disclaimer, a copy of which may be read at http://learning.longhill.org.uk/disclaimer

Can you try the code in the attached branch and let me know.

It works well, it correctly changes the layout both if I change
its default layout and if I change its contents.

Thank you
Andrea