OpenLP

OpenSong importer: wrong verse order

Bug #648263 reported by Gyuris Gellért on 2010-09-26

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenLP	Fix Released	Medium	mahfiaz	OpenLP 1.9.5 "Maverick Micah"

Bug Description

It seems to me, the importer only copy the OpenSong verse order, and does not "translate" to OpenLP style.
For example, see the attachment song/screenshot:
- OpenSong verse order was unspecified (but if it is given, it does not matter), so: "V1 B C"
- The imported verse order is: "V1 B1 C1"
- But, should be: "V1 M1 R1"
The sequence refers on no-existing element.

Tags:

Related branches

lp://qastaging/~mahfiaz/openlp/opensongfixes

Merged into lp://qastaging/openlp at revision 1310

Raoul Snyman: Approve on 2011-02-18

Jon Tibble (community): Approve on 2011-02-18

Tim Bentley: Needs Fixing on 2011-02-18

Revision history for this message

Gyuris Gellért (gellert-gyuris) wrote on 2010-09-26:

Screenshot Edit (33.4 KiB, image/png)

Revision history for this message

Gyuris Gellért (gellert-gyuris) wrote on 2010-09-26:

Original OpenSong file Edit (732 bytes, text/xml)

Raoul Snyman (raoul-snyman) on 2010-09-26

Changed in openlp:
milestone:	none → 1.9.4
assignee:	nobody → Martin Thompson (mjthompson)
assignee:	Martin Thompson (mjthompson) → nobody
assignee:	nobody → Martin Thompson (mjthompson)
importance:	Undecided → Medium

Revision history for this message

Martin Thompson (mjthompson) wrote on 2010-09-27:

Thanks Gyuris.

Your opensong file seems (to me) to say V1, B, C *is* the correct order - those are the tags used in there. Where are the M and R coming from?

Is the issue a translation one? Should we be displaying "B"as "M" and "R" as "C"? (By the way, what are M and R short for?)

Sorry, I don't seem to be understanding the problem sufficiently to fix it!

Revision history for this message

Gyuris Gellért (gellert-gyuris) wrote on 2010-09-27:

image2826.png Edit (50.3 KiB, image/png)

Hi, see the attached picture (English version).
"M" and "R" is coming from warning message.
I think, this is not a translation issues (I'm the Hungarian translator).
I hope, this helps.

Revision history for this message

Martin Thompson (mjthompson) wrote on 2010-09-27:

Right, I see now. I'm still not clear where the M and R are coming from though. as I see it:
* The original song has V1, B and C in
* The importer has set the order as V1, B and C also
* The song editor is now using (I assume) Hungarian labelling.

Have I understood correctly this time?

If so, I think this must be coming from "outside" of the importer somewhere, as I'm just pushing the V,B,C at the database.

Martin Thompson (mjthompson) on 2010-09-27

Changed in openlp:
assignee:	Martin Thompson (mjthompson) → nobody

Revision history for this message

Jonathan Corwin (j-corwin) wrote on 2010-09-27:

There is a wider issue here. For some reason we're holding translated verse identifiers in the database. This is bad, especially if people switch between languages, e.g. add some songs in English, and then switch to another language later when the translation is completed.

So first thing is to ensure database is always in English
Then we need to translate when song is loaded, and translate back to English when saved. Verse order will need translating too.

Andreas Preikschat (googol-deactivatedaccount) on 2010-10-12

tags:

added: opensong-import

Raoul Snyman (raoul-snyman) on 2010-11-23

Changed in openlp:
assignee:	nobody → Martin Thompson (mjthompson)

Tim Bentley (trb143) on 2011-01-08

Changed in openlp:
milestone:	1.9.4 → 1.9.5

Revision history for this message

Andreas Preikschat (googol-deactivatedaccount) wrote on 2011-01-21:

Hm... I just had some problems with the openlp.org v1 importer. It added the verses with a "Strophe" attribute, instead of a "Verse" attribute to the db. But as the verse order is not translated, I could not view any of my songs.

As this is a fundamental problem, I think we should hurry to fix this.

mahfiaz (mahfiaz) on 2011-02-16

Changed in openlp:
assignee:	Martin Thompson (mjthompson) → mahfiaz (mahfiaz)
status:	New → In Progress

Revision history for this message

mahfiaz (mahfiaz) wrote on 2011-02-19:

This should be resolved in the trunk in revision 1310. The tested file imports fine on my machine.
Also now the verse order is inserted only when this actually has meaning (it was originally present/some duplicate verses were left out). Please test it yourself and let us know if anything is wrong or does not work as expected.