Ubuntu
reiserfsprogs package

FTBFS in edgy: no asm/unaligned.h

Bug #65842 reported by Fabio Massimo Di Nitto
2
Affects Status Importance Assigned to Milestone
linux-source-2.6.17 (Ubuntu)
Invalid
High
Ben Collins
Ubuntu ubuntu-6.10
reiserfsprogs (Ubuntu)
Fix Released
High
Martin Pitt
Ubuntu ubuntu-6.10

Bug Description

if i486-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../include -Wall -g -O2 -fPIC -DPIC -MT do_balan.o -MD -MP -MF ".deps/do_balan.Tpo" \
          -c -o do_balan.o `test -f 'do_balan.c' || echo './'`do_balan.c; \
        then mv -f ".deps/do_balan.Tpo" ".deps/do_balan.Po"; \
        else rm -f ".deps/do_balan.Tpo"; exit 1; \
        fi
In file included from ../include/reiserfs_lib.h:14,
                 from includes.h:12,
                 from do_balan.c:20:
../include/reiserfs_fs.h:41:27: error: asm/unaligned.h: No such file or directory
make[2]: *** [do_balan.o] Error 1
make[2]: Leaving directory `/usr/src/ubuntu/foo/reiserfsprogs-3.6.19/reiserfscore'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/src/ubuntu/foo/reiserfsprogs-3.6.19'
make: *** [build-stamp] Error 2

Fabio Massimo Di Nitto (fabbione)
Changed in reiserfsprogs:
assignee: nobody → pitti
importance: Undecided → High
status: Unconfirmed → Confirmed
Martin Pitt (pitti)
Changed in reiserfsprogs:
status: Confirmed → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Ben, linux-libc-dev does not provide asm/unaligned.h any more. Using the macros get_unaligned and put_unaligned in low-level userspace programs like reiserfsprogs seems quite legitimate to me. Can this be put back, or was there a specific reason to not include it any more?

Changed in linux-source-2.6.17:
assignee: nobody → ben-collins
importance: Undecided → High
status: Unconfirmed → Needs Info
Revision history for this message
Martin Pitt (pitti) wrote :

<BenC> pitti: main reason is that sparc64 uses asm-generic/unaligned.h and that can't be in userspace
<BenC> pitti: From what I can tell, accessing unaligned data is not a problem, and get_unaligned/put_unaligned is only important for some architectures to improve performance a bit
<BenC> and from what I can tell, that's only the case for sparc64 for us
<BenC> the other arch's, the macros are pretty much (foo) and (foo = bar)

Changed in linux-source-2.6.17:
status: Needs Info → Rejected
Revision history for this message
Martin Pitt (pitti) wrote :

 reiserfsprogs (1:3.6.19-3ubuntu1) edgy; urgency=low
 .
   * include/reiserfs_fs.h: Do not #include <asm/unaligned.h>. It does not
     exist any more and should not be necessary on our architectures. Instead
     define {get,put}_aligned macros as naive macros. Fixes FTBFS.
     Closes: LP#65842

Changed in reiserfsprogs:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.