Maintain Control Numbers global flag creates unnecessary 035 when creating a record from scratch

Bug #673865 reported by Dan Scott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Dan Scott

Bug Description

Evergreen 2.0 beta 1

From http://libmail.georgialibraries.org/pipermail/open-ils-dev/2010-November/006474.html :

Repke de Vries wrote:

When in 2.0 alpha4 Adding a MFHD Record, the default LDR, 001, 005,
004, 008 are fine (can't judge the 901 $o).

However, the 035 should not happen: this the very first time a MFHD record
is created; only if some other library would take IISH's Holding
Records, the IISH 001 and 003 should be pushed to the 035

Dan Scott wrote:
> Agreed. Just to explain what's going on under the covers is that the
> MFHD record is created with an auto-generated TCN (001), then when the
> record is inserted into the database the update trigger runs and the 001
> gets replaced with the record ID and the old 001 gets pushed into the
> 035.
>
> I can't guarantee that we'll be able to fix this before the 2.0 release.
> It would be great, though, if you could at least create a bug for this
> so that we can at least track it.
>

Mike Rylander wrote:
Just a thought on implementation ... since the goal is to detect when
the record is brand new, as opposed to updated, perhaps we just need
to test whether create_date and edit_date are the same and if so we
can skip the 035 dance.

And Dan Scott wrote:
I got to the point of implementing this, then realized that there's
currently not a good way (that my sleep-deprived brain can think of, at
least) for the trigger to distinguish between a new record that was
imported via Z39.50 (where you would _want_ to push the 001/003 into the
035) and a new record that was created from scratch (where you would
want to just overwrite the 001/003 without creating a 035).

Revision history for this message
Dan Scott (denials) wrote :

There was a fix committed to beta2, but a more robust version of maintain_control_numbers will be in beta3.

It only generates a 035 if there is exactly 1 001 and 1 003 in the incoming record, so if you are creating a new record from a template, if your template does not have a 001 and a 003 in it, you should be good to go; the 001 and 003 will be filled in automatically for you once you save the record.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: nobody → Dan Scott (denials)
milestone: none → 2.0beta3
Dan Scott (denials)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.