server_base.py unnecessarily monkey patches python-couchdb
Bug #676212 reported by
Eric Casteleijn
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| desktopcouch |
Fix Released
|
Medium
|
Eric Casteleijn | ||
| desktopcouch (Ubuntu) |
Fix Released
|
Medium
|
Eric Casteleijn | ||
Bug Description
The get_changes function in server_base.py that is used to monkey patch python-couchdb's database object is unnecessary:
1. It says it's there to circumvent incorrectly encoded slashes, yet the _changes url contains no slashes
2. even if we needed to go around the original, we could do it in CouchDatabaseBase, rather than monkey patch.
Related branches
lp://qastaging/~thisfred/desktopcouch/kill-the-monkey
- Vincenzo Di Somma (community): Approve
- Chad Miller (community): Approve
-
Diff: 80 lines (+10/-29)1 file modifieddesktopcouch/records/server_base.py (+10/-29)
| Changed in desktopcouch: | |
| assignee: | nobody → Eric Casteleijn (thisfred) |
| status: | Triaged → In Progress |
| Changed in desktopcouch: | |
| status: | In Progress → Fix Committed |
| Changed in desktopcouch (Ubuntu): | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| assignee: | nobody → Eric Casteleijn (thisfred) |
| milestone: | none → natty-alpha-1 |
| Changed in desktopcouch (Ubuntu): | |
| milestone: | natty-alpha-1 → natty-alpha-2 |
| Changed in desktopcouch: | |
| status: | Fix Committed → Fix Released |
| Changed in desktopcouch (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
