photometric optimisation seems to ignore image settings

Bug #678890 reported by esby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Hugin
Expired
High
Unassigned

Bug Description

concerns: hugin 0.7.0.3113

I don't know if this is a bug or not.

Maybe it's not, maybe it's several bugs:

Try to run a photometric optimisation of a given panorama with various luminous range
ie: the sun is present in the panorama and is 'degradding' it.

1-
If you uncheck all option and runs the optimisation, the photometric values will change...
I may be wrong, but photometrics values should not change if no settings is checked...

2- If you try to optimize all images except a given few images:
The optimizer will ignore your settings and will optimizes all images...

If you need a few images showing the problem, I can upload them somewhere. Anyway, it's not specific to images but generic to any photometric optimization

Revision history for this message
esby (esby) wrote :

Logged In: YES
user_id=879770
Originator: YES

I also forgot to mention that colorimetric red/blue parameters do not seem to have any effect on the preview window.

Revision history for this message
rew (r-e-wolff) wrote :

This is now an "instant crash". Autosave would've been handy here...

What I did (and I can reproduce this cleanly).

load 23 images with the assistant. I have "auto align" turned on since this morning, so it ends up showing me the preview.

Next go to "exposure tab", select "custom parameters", deselect all "to optimize" variables, hit optimize.

(Maybe it matters: My images don't have exif. (if it doesn't reproduce on normal camera pictures use djpeg <image> | cjpeg > <newimage> and use the new images.))

rew (r-e-wolff)
Changed in hugin:
status: New → Confirmed
importance: Undecided → High
Yuv (yuv)
tags: added: crash optimizer photometric
Revision history for this message
tmodes (tmodes) wrote :

The "instant" crash is fixed (rev. 57fcdd6c2c89). A warning shows currently only up in default branch (rev. ed99ae8486d6), not sure if this should also go into 2010.4 branch, because it introduces new strings for translations.

What's about the original report, is point 2 still valid?

Revision history for this message
Yuv (yuv) wrote : Re: [Bug 678890] Re: photometric optimisation seems to ignore image settings

On December 4, 2010 03:08:12 pm tmodes wrote:
> The "instant" crash is fixed (rev. 57fcdd6c2c89). A warning shows
> currently only up in default branch (rev. ed99ae8486d6), not sure if
> this should also go into 2010.4 branch, because it introduces new
> strings for translations.

If the trade-off is between the beauty of a translated string and the function
of fixing an instant crash, I'd rather fix the instant crash. Easy.

If the trade-off is against a silent unexplained non-response (as I understand
the first half of the fix currently in 2010.4), I am still in favor of adding
the explanation = string, even if there are chances that it does not get
translated and that the application looks unpolished.

On with it into 2010.4 and out with a message to translators.

I take care of it *now* - I hit the send button here, I update the strings for
translation in default, copy the changesets to 2010.4 and issue a note to
translators on Hugin-PTX.

Yuv

Revision history for this message
Yuv (yuv) wrote :

From original report:
> 2- If you try to optimize all images except a given few images:
> The optimizer will ignore your settings and will optimizes all images...

does this still happen?

Changed in hugin:
status: Confirmed → Incomplete
Revision history for this message
esby (esby) wrote :

Tested with hugin 2010.5.0.b5a907b23b85 (from ppa nightly build)

Could not reproduce the issue.

Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for Hugin because there has been no activity for 60 days.]

Changed in hugin:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.